[webkit-changes] [WebKit/WebKit] 271494: Stop using a raw pointer for Node::m_treeScope

Chris Dumez noreply at github.com
Mon Oct 23 19:56:57 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2714943f80da611b6d992d9aa457ba9c5c2f633a
      https://github.com/WebKit/WebKit/commit/2714943f80da611b6d992d9aa457ba9c5c2f633a
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-10-23 (Mon, 23 Oct 2023)

  Changed paths:
    M Source/WTF/wtf/Ref.h
    M Source/WTF/wtf/RefPtr.h
    M Source/WTF/wtf/TypeCasts.h
    M Source/WebCore/dom/Node.cpp
    M Source/WebCore/dom/Node.h
    M Source/WebCore/dom/ShadowRoot.h
    M Source/WebCore/dom/TreeScope.cpp
    M Source/WebCore/dom/TreeScope.h

  Log Message:
  -----------
  Stop using a raw pointer for Node::m_treeScope
https://bugs.webkit.org/show_bug.cgi?id=262239
rdar://116501041

Reviewed by Ryosuke Niwa.

* Source/WTF/wtf/Ref.h:
(WTF::checkedDowncast):
* Source/WTF/wtf/RefPtr.h:
(WTF::checkedDowncast):
* Source/WTF/wtf/TypeCasts.h:
(WTF::checkedDowncast):
Introduce checkedDowncast<>(), which is similar to downcast<>() but the
type check happens in release builds too for extra safety.

* Source/WebCore/dom/Node.cpp:
(WebCore::Node::Node):
(WebCore::Node::~Node):
* Source/WebCore/dom/Node.h:
* Source/WebCore/dom/ShadowRoot.h:
* Source/WebCore/dom/TreeScope.cpp:
(WebCore::TreeScope::incrementPtrCount const):
(WebCore::TreeScope::decrementPtrCount const):
* Source/WebCore/dom/TreeScope.h:

Canonical link: https://commits.webkit.org/269692@main




More information about the webkit-changes mailing list