[webkit-changes] [WebKit/WebKit] 21002e: REGRESSION(269643 at main) AX: Summary elements are n...
Tyler Wilcock
noreply at github.com
Mon Oct 23 18:23:25 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 21002ed8c1d123439659759bd9fcb303e414d5d0
https://github.com/WebKit/WebKit/commit/21002ed8c1d123439659759bd9fcb303e414d5d0
Author: Tyler Wilcock <tyler_w at apple.com>
Date: 2023-10-23 (Mon, 23 Oct 2023)
Changed paths:
M LayoutTests/accessibility/mac/search-predicate-summary-expected.txt
M LayoutTests/accessibility/mac/search-predicate-summary.html
M Source/WebCore/accessibility/AccessibilityObject.cpp
Log Message:
-----------
REGRESSION(269643 at main) AX: Summary elements are not expandable by macOS VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=263534
rdar://problem/117359988
Reviewed by Andres Gonzalez.
Regression from:
https://bugs.webkit.org/show_bug.cgi?id=263499
Claiming "supports press action" for summary elements is not correct, and actually regresses this functionality.
This patch undoes that part of https://bugs.webkit.org/show_bug.cgi?id=263499, and adds testcases and documentation
to prevent this mistake in the future.
* LayoutTests/accessibility/mac/search-predicate-summary-expected.txt:
* LayoutTests/accessibility/mac/search-predicate-summary.html:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::supportsPressAction const):
Canonical link: https://commits.webkit.org/269688@main
More information about the webkit-changes
mailing list