[webkit-changes] [WebKit/WebKit] 551c2e: wasm.yaml/wasm/lowExecutableMemory/imports-oom.js....

Michael Saboff noreply at github.com
Mon Oct 23 16:55:15 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 551c2ebfb07ae634e4e893c2fa4ecefda920bbc9
      https://github.com/WebKit/WebKit/commit/551c2ebfb07ae634e4e893c2fa4ecefda920bbc9
  Author: Michael Saboff <msaboff at apple.com>
  Date:   2023-10-23 (Mon, 23 Oct 2023)

  Changed paths:
    M JSTests/wasm/lowExecutableMemory/exports-oom.js
    M JSTests/wasm/lowExecutableMemory/imports-oom.js
    M Source/JavaScriptCore/wasm/WasmCalleeGroup.cpp
    M Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp

  Log Message:
  -----------
  wasm.yaml/wasm/lowExecutableMemory/imports-oom.js.default-wasm is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=244122
rdar://98882300

Reviewed by Justin Michaud.

Fixed two issues.
1) If we run out of memory when creating a LLIntPlan in the CalleeGroup constructor, we now error out.
2) If we run out of memory when compiling / linking the JS to Wasm IC callee, we error out instead of
   creating a JSToWasmICCallee that doesn't have and entrypoint.

Re-enabled exports-oom.js and imports-oom.js tests.

* JSTests/wasm/lowExecutableMemory/exports-oom.js:
* JSTests/wasm/lowExecutableMemory/imports-oom.js:
* Source/JavaScriptCore/wasm/WasmCalleeGroup.cpp:
(JSC::Wasm::CalleeGroup::CalleeGroup):
* Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp:
(JSC::WebAssemblyFunction::jsCallEntrypointSlow):

Canonical link: https://commits.webkit.org/269682@main




More information about the webkit-changes mailing list