[webkit-changes] [WebKit/WebKit] 68f1a3: Stabilise attachment-uti.html with reftest-wait an...

Gerald Squelart noreply at github.com
Mon Oct 23 14:43:00 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 68f1a337127aec08290217e19bc40ac142103093
      https://github.com/WebKit/WebKit/commit/68f1a337127aec08290217e19bc40ac142103093
  Author: Gerald Squelart <g_squelart at apple.com>
  Date:   2023-10-23 (Mon, 23 Oct 2023)

  Changed paths:
    M LayoutTests/fast/attachment/attachment-uti-expected.html
    M LayoutTests/fast/attachment/attachment-uti.html
    M LayoutTests/platform/mac-wk1/TestExpectations
    M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  -----------
  Stabilise attachment-uti.html with reftest-wait and takeScreenshotWhenAttachmentsSettled
https://bugs.webkit.org/show_bug.cgi?id=263085
rdar://116877284

Reviewed by Aditya Keerthi.

Attachment-uti.html was flaky, with the actual and/or expected rendering
sometimes missing the icon, because that icon is only fetched during the
first rendering. Use reftest-wait and takeScreenshotWhenAttachmentsSettled
to delay the test screenshot until there is an icon.

* LayoutTests/fast/attachment/attachment-uti-expected.html:
* LayoutTests/fast/attachment/attachment-uti.html:
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/269670@main




More information about the webkit-changes mailing list