[webkit-changes] [WebKit/WebKit] d40154: Empty WebVTT files should not succeed in loading

[Kohei Ueno]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d40154a4fe8f153060d3b85bc29baf5f50ebefff
      https://github.com/WebKit/WebKit/commit/d40154a4fe8f153060d3b85bc29baf5f50ebefff
  Author: Kohei Ueno <kohei.ueno119 at gmail.com>
  Date:   2023-10-23 (Mon, 23 Oct 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/signature-invalid-expected.txt
    R LayoutTests/media/track/captions-webvtt/tc000-empty.vtt
    R LayoutTests/media/track/track-webvtt-tc000-empty-expected.txt
    R LayoutTests/media/track/track-webvtt-tc000-empty.html
    M Source/WebCore/loader/TextTrackLoader.cpp

  Log Message:
  -----------
  Empty WebVTT files should not succeed in loading
https://bugs.webkit.org/show_bug.cgi?id=260409

Reviewed by Eric Carlson.

Empty WebVTT files don't have a valid signature, so they should fail
the signature check and result in loading failure. This patch adds
the check if the resource is empty before attempting to parse it.
And also the old test case is removed since it's not valid anymore
in favor of the WPT.

* LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/signature-invalid-expected.txt:
* LayoutTests/media/track/captions-webvtt/tc000-empty.vtt: Removed.
* LayoutTests/media/track/track-webvtt-tc000-empty-expected.txt: Removed.
* LayoutTests/media/track/track-webvtt-tc000-empty.html: Removed.
* Source/WebCore/loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::notifyFinished):

Canonical link: https://commits.webkit.org/269646@main