[webkit-changes] [WebKit/WebKit] c69c97: AX: details/summary not included in VoiceOver Form...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c69c97c046fd5b44688eb842e644ae3cb36c5bd2
      https://github.com/WebKit/WebKit/commit/c69c97c046fd5b44688eb842e644ae3cb36c5bd2
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-10-22 (Sun, 22 Oct 2023)

  Changed paths:
    A LayoutTests/accessibility/ios-simulator/activate-summary-expected.txt
    A LayoutTests/accessibility/ios-simulator/activate-summary.html
    A LayoutTests/accessibility/mac/search-predicate-summary-expected.txt
    A LayoutTests/accessibility/mac/search-predicate-summary.html
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
    M Source/WebCore/accessibility/AccessibilityNodeObject.h
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
    M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm

  Log Message:
  -----------
  AX: details/summary not included in VoiceOver Form Controls menu or list
https://bugs.webkit.org/show_bug.cgi?id=263499
rdar://problem/117308226

Reviewed by Chris Fleizach.

This is fixed on iOS by exposing summary text as a button (as pressing it toggles the containing details open state).

On macOS, AXControlSearchKey is modified to include summary elements (consistent with the fact that we expose them as
buttons prior to this patch). We also modify AccessibilityObject::supportsPressAction to help indicate their interacive
state.

This patch also fixes a bug on iOS where a details element with a user-agent default summary did not expand or collapse
when activated via VoiceOver.

* LayoutTests/accessibility/ios-simulator/activate-summary-expected.txt: Added.
* LayoutTests/accessibility/ios-simulator/activate-summary.html: Added.
* LayoutTests/accessibility/mac/search-predicate-summary-expected.txt: Added.
* LayoutTests/accessibility/mac/search-predicate-summary.html: Added.
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::toggleDetailsAncestor):
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::supportsPressAction const):
(WebCore::Accessibility::isAccessibilityObjectSearchMatchAtIndex):
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::toggleDetailsAncestor):
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored const):
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _accessibilityTraitsFromAncestors]):
(-[WebAccessibilityObjectWrapper accessibilityTraits]):
(-[WebAccessibilityObjectWrapper _accessibilityActivate]):

Canonical link: https://commits.webkit.org/269643@main