[webkit-changes] [WebKit/WebKit] 4ab4d8: [popover] Using nested shadow DOM wrongly auto-hid...

Luke Warlow noreply at github.com
Fri Oct 20 15:03:13 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4ab4d83515295e0a665d55c86ce55d5ff35ca226
      https://github.com/WebKit/WebKit/commit/4ab4d83515295e0a665d55c86ce55d5ff35ca226
  Author: Luke Warlow <luke at warlow.dev>
  Date:   2023-10-20 (Fri, 20 Oct 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-flat-tree-nested-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-flat-tree-nested.html
    M LayoutTests/platform/ios-wk2/TestExpectations
    M Source/WebCore/html/HTMLElement.cpp

  Log Message:
  -----------
  [popover] Using nested shadow DOM wrongly auto-hides popover by light dismiss
https://bugs.webkit.org/show_bug.cgi?id=263081

Reviewed by Ryosuke Niwa.

Use the flat tree as mandated by the spec when calculating the nearest inclusive open popoer:
- https://html.spec.whatwg.org/#nearest-inclusive-open-popover

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-flat-tree-nested-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-flat-tree-nested.html: Added.
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::topmostPopoverAncestor):
* LayoutTests/platform/ios-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/269596@main




More information about the webkit-changes mailing list