[webkit-changes] [WebKit/WebKit] 07b011: [web-animations] linear() probably does not work w...

Antoine Quint noreply at github.com
Fri Oct 20 14:39:06 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 07b0116f3ef9d91fa6828fe1dd52fe77c8108c04
      https://github.com/WebKit/WebKit/commit/07b0116f3ef9d91fa6828fe1dd52fe77c8108c04
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-10-20 (Fri, 20 Oct 2023)

  Changed paths:
    A LayoutTests/webanimations/combining-transform-animations-with-different-acceleration-capabilities-6-expected.txt
    A LayoutTests/webanimations/combining-transform-animations-with-different-acceleration-capabilities-6.html
    M Source/WebCore/animation/KeyframeEffect.cpp
    M Source/WebCore/animation/KeyframeEffect.h

  Log Message:
  -----------
  [web-animations] linear() probably does not work with transform and other accelerated properties
https://bugs.webkit.org/show_bug.cgi?id=260136
rdar://114084978

Reviewed by Dean Jackson.

Devin Rousso added support for the `linear()` timing function in 266195 at main. That initial patch
did not account for the lack of a Core Animation equivalent for this timing function, which meant
that accelerated properties would fail to respect this timing function.

We now use the same mechanism we use for the `steps()` timing function for `linear()`.

* LayoutTests/webanimations/combining-transform-animations-with-different-acceleration-capabilities-6-expected.txt: Added.
* LayoutTests/webanimations/combining-transform-animations-with-different-acceleration-capabilities-6.html: Added.
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::setBlendingKeyframes):
(WebCore::isLinearTimingFunctionWithPoints):
(WebCore::KeyframeEffect::computeSomeKeyframesUseStepsOrLinearTimingFunctionWithPoints):
(WebCore::KeyframeEffect::canBeAccelerated const):
(WebCore::KeyframeEffect::animationDidChangeTimingProperties):
(WebCore::KeyframeEffect::computeSomeKeyframesUseStepsTimingFunction): Deleted.
* Source/WebCore/animation/KeyframeEffect.h:

Canonical link: https://commits.webkit.org/269594@main




More information about the webkit-changes mailing list