[webkit-changes] [WebKit/WebKit] 3144f3: PerformanceTests/IndexedDB/stress tests use one da...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3144f3ca572e6621959e68562e2569ff3cbd3ded
      https://github.com/WebKit/WebKit/commit/3144f3ca572e6621959e68562e2569ff3cbd3ded
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2023-10-20 (Fri, 20 Oct 2023)

  Changed paths:
    M PerformanceTests/IndexedDB/stress/large-array-keys.html
    M PerformanceTests/IndexedDB/stress/large-binary-keys.html
    M PerformanceTests/IndexedDB/stress/large-number-of-inserts-responsiveness.html
    M PerformanceTests/IndexedDB/stress/large-number-of-inserts.html
    M PerformanceTests/IndexedDB/stress/large-string-keys.html

  Log Message:
  -----------
  PerformanceTests/IndexedDB/stress tests use one database for all iterations unexpectedly
https://bugs.webkit.org/show_bug.cgi?id=263437
rdar://117257501

Reviewed by Youenn Fablet and Brady Eidson.

The done function passed to PerfTestRunner is invoked at the end of all test iterations, not at the end of each
iteration. That means, currentIteration is not updated between iterations and all iterations use the same database (as
database name is created based on currentIteration value). This can lead to misleading results. For example, only the
first iteration spends time in opening the database and the other iterations don't; only the first iteration is adding
items to database, and the other iterations are updating items (since we use put() function in tests).

To fix this, ensure the clean up tasks happen after each test iteration, and tests use different database for different
iterations.

* PerformanceTests/IndexedDB/stress/large-array-keys.html:
* PerformanceTests/IndexedDB/stress/large-binary-keys.html:
* PerformanceTests/IndexedDB/stress/large-number-of-inserts-responsiveness.html:
* PerformanceTests/IndexedDB/stress/large-number-of-inserts.html:
* PerformanceTests/IndexedDB/stress/large-string-keys.html:

Canonical link: https://commits.webkit.org/269584@main