[webkit-changes] [WebKit/WebKit] d87254: [ews-build] run-api-tests step should fail builds ...

Aakash J noreply at github.com
Fri Oct 20 12:36:18 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d87254aa4b2936116573a8f1c6cac118dd78cb43
      https://github.com/WebKit/WebKit/commit/d87254aa4b2936116573a8f1c6cac118dd78cb43
  Author: Aakash Jain <aakash_jain at apple.com>
  Date:   2023-10-20 (Fri, 20 Oct 2023)

  Changed paths:
    M Tools/CISupport/ews-build/steps.py

  Log Message:
  -----------
  [ews-build] run-api-tests step should fail builds that exceed a predefined threshold of log lines
https://bugs.webkit.org/show_bug.cgi?id=263450

Reviewed by Jonathan Bedard and Elliott Williams.

* Tools/CISupport/ews-build/steps.py:
(CompileWebKit.handleExcessiveLogging): Drive-by fix.
(RunAPITests): Stop subclassing from TestWithFailureCount which uses BufferLogObserver.
(RunAPITests.run):
(RunAPITests.parseOutputLine): Parse each log ling as it comes.
(RunAPITests.handleExcessiveLogging): Handle excessive logging by stopping the build.
(RunAPITests.getResultSummary): Custom failure message.
(RunAPITests.countFailures): Deleted. Re-implemented in parseOutputLine.

Canonical link: https://commits.webkit.org/269577@main




More information about the webkit-changes mailing list