[webkit-changes] [WebKit/WebKit] 89775b: REGRESSION: WebKit provides rectilinear selection ...

Richard Robinson noreply at github.com
Fri Oct 20 10:38:42 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 89775b5ff064e50f6a1177def010eca32b2cbea3
      https://github.com/WebKit/WebKit/commit/89775b5ff064e50f6a1177def010eca32b2cbea3
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2023-10-20 (Fri, 20 Oct 2023)

  Changed paths:
    M Source/WebKit/Shared/EditorState.cpp

  Log Message:
  -----------
  REGRESSION: WebKit provides rectilinear selection rects for rotated text in images
https://bugs.webkit.org/show_bug.cgi?id=259888
rdar://113287677

Reviewed by Wenson Hsieh.

`EditorState::clipOwnedRectExtentsToNumericLimits` was erroneously converting some selection
geometries from quads to rects.

Fix by removing these conversions. Since `FloatQuad`s have no notion of validity, there is no
need to clip them to numeric limits.

* Source/WebKit/Shared/EditorState.cpp:
(WebKit::EditorState::clipOwnedRectExtentsToNumericLimits):

Canonical link: https://commits.webkit.org/265870.235@safari-7616-branch

Canonical link: https://commits.webkit.org/269572@main




More information about the webkit-changes mailing list