[webkit-changes] [WebKit/WebKit] 5a023a: [CoordinatedGraphics] Remove CompositingCoordinato...

Carlos Garcia Campos noreply at github.com
Fri Oct 20 04:27:17 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5a023aa726196215720ffeeffccda978615dd478
      https://github.com/WebKit/WebKit/commit/5a023aa726196215720ffeeffccda978615dd478
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2023-10-20 (Fri, 20 Oct 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp
    M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h
    M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp
    M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h
    M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp

  Log Message:
  -----------
  [CoordinatedGraphics] Remove CompositingCoordinator::syncLayerState()
https://bugs.webkit.org/show_bug.cgi?id=263368

Reviewed by Žan Doberšek.

The coordinator calls syncPendingStateChangesIncludingSubLayers on the
root graphics layer, that doesn't really sync anything, every layer
checks if there's a pending stater sync and calls
CompositingCoordinator::syncLayerState() to mark m_shouldSyncFrame as
true. We can remove the dependency of the layer on the compositor by
making syncPendingStateChangesIncludingSubLayers return whether the sync
should happen or not.

* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::checkPendingStateChangesIncludingSubLayers):
(WebCore::CoordinatedGraphicsLayer::syncPendingStateChangesIncludingSubLayers): Deleted.
* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:
(WebKit::CompositingCoordinator::flushPendingLayerChanges):
(WebKit::CompositingCoordinator::initializeRootCompositingLayerIfNeeded):
(WebKit::CompositingCoordinator::syncLayerState): Deleted.
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::layerFlushTimerFired):
(WebKit::LayerTreeHost::renderNextFrame):

Canonical link: https://commits.webkit.org/269560@main




More information about the webkit-changes mailing list