[webkit-changes] [WebKit/WebKit] 38294b: Add canvas noise injection test

[Matthew Finkel]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 38294bd0b5d959b1c43be0caee0460d5cd3721a5
      https://github.com/WebKit/WebKit/commit/38294bd0b5d959b1c43be0caee0460d5cd3721a5
  Author: Matthew Finkel <sysrqb at apple.com>
  Date:   2023-10-19 (Thu, 19 Oct 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    A LayoutTests/fast/canvas/canvas-noise-injection-expected.txt
    A LayoutTests/fast/canvas/canvas-noise-injection.html
    M Source/WebCore/html/CanvasBase.h
    M Source/WebCore/html/CanvasNoiseInjection.h
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebCore/testing/Internals.idl

  Log Message:
  -----------
  Add canvas noise injection test
https://bugs.webkit.org/show_bug.cgi?id=263094
rdar://116886810

Reviewed by Simon Fraser.

Noise injection should only be applied when the feature is enabled (i.e., when
a salt value is set), and it should not be applied when the canvas only
contains bitmap data (e.g., drawImage, putImageData).

This test fail the latter expectation, and that will be fixed in a follow-up
patch.

This patch exposes some internal state via Internals.

* LayoutTests/TestExpectations:
* LayoutTests/fast/canvas/canvas-noise-injection-expected.txt: Added.
* LayoutTests/fast/canvas/canvas-noise-injection.html: Added.
* Source/WebCore/html/CanvasBase.h:
(WebCore::CanvasBase::setNoiseInjectionSalt):
(WebCore::CanvasBase::havePendingCanvasNoiseInjection const):
* Source/WebCore/html/CanvasNoiseInjection.h:
(WebCore::CanvasNoiseInjection::haveDirtyRects const):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::setCanvasNoiseInjectionSalt):
(WebCore::Internals::doesCanvasHavePendingCanvasNoiseInjection const):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:

Canonical link: https://commits.webkit.org/269541@main