[webkit-changes] [WebKit/WebKit] fcbf06: [ iOS17 ] TestWebKitAPI.AutocorrectionTests.FontAt...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fcbf065e192954578678887bf38fd0175140f2b8
      https://github.com/WebKit/WebKit/commit/fcbf065e192954578678887bf38fd0175140f2b8
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-10-19 (Thu, 19 Oct 2023)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm

  Log Message:
  -----------
  [ iOS17 ] TestWebKitAPI.AutocorrectionTests.FontAtCaretWhenUsingUICTFontTextStyle is constantly failing.
https://bugs.webkit.org/show_bug.cgi?id=263125
rdar://116924205

Reviewed by Richard Robinson.

Make this test robust against minor differences in the size of text rects used for autocorrection when using
`UICTFontTextStyle`. This test appears to fail with an autocorrection bubble width of 24 instead of 20 after recent EWS
updates to iOS 17, though it still seems to pass (i.e. rect width = 20) when running locally. It's unclear what's
causing this disparity.

The purpose of this test isn't to check the specific autocorrection rect geometry in the first place, so we should just
make this more robust and check that non-empty autocorrection rects appear.

* Tools/TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
(checkCGRectIsNotEmpty):
(checkCGRectIsEqualToCGRectWithLogging): Deleted.

Canonical link: https://commits.webkit.org/269533@main