[webkit-changes] [WebKit/WebKit] c7356a: [IFC] Fallback to full invalidation when first-let...

Alan Baradlay noreply at github.com
Thu Oct 19 06:36:06 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c7356ae7aaa308c9724a3cbff83e1f1344fb5cba
      https://github.com/WebKit/WebKit/commit/c7356ae7aaa308c9724a3cbff83e1f1344fb5cba
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-10-19 (Thu, 19 Oct 2023)

  Changed paths:
    A LayoutTests/fast/text/first-letter-partial-invalidation-crash-expected.txt
    A LayoutTests/fast/text/first-letter-partial-invalidation-crash.html
    M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp

  Log Message:
  -----------
  [IFC] Fallback to full invalidation when first-letter is present
https://bugs.webkit.org/show_bug.cgi?id=263182
<rdar://116449508>

Reviewed by Antti Koivisto.

RenderTreeUpdater::updateTextRenderer computes inconsistent values for the damage offset when first-letter is present which confuses inline layout invalidation.
Let's disable partial layout for content with first-letter for now (enable is blocked by webkit.org/b/263343).

* LayoutTests/fast/text/first-letter-partial-invalidation-crash-expected.txt: Added.
* LayoutTests/fast/text/first-letter-partial-invalidation-crash.html: Added.
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::shouldInvalidateLineLayoutPathAfterChangeFor):

Canonical link: https://commits.webkit.org/269519@main




More information about the webkit-changes mailing list