[webkit-changes] [WebKit/WebKit] fcec2d: Generate serialization of WebKit::RTCNetwork

Alex Christensen noreply at github.com
Wed Oct 18 20:23:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fcec2d7bc72b88bce82d21af80190c9493772902
      https://github.com/WebKit/WebKit/commit/fcec2d7bc72b88bce82d21af80190c9493772902
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-10-18 (Wed, 18 Oct 2023)

  Changed paths:
    M Source/WebKit/Shared/RTCNetwork.cpp
    M Source/WebKit/Shared/RTCNetwork.h
    M Source/WebKit/Shared/RTCNetwork.serialization.in
    M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.cpp

  Log Message:
  -----------
  Generate serialization of WebKit::RTCNetwork
https://bugs.webkit.org/show_bug.cgi?id=263330
rdar://117153936

Reviewed by Youenn Fablet.

The previous attempt didn't update RTCNetwork::value to reflect that name and description
are no longer null terminated so they need to include their length in the absl::string_view
constructor.  That caused a test to become flaky.  Hopefully this won't.

* Source/WebKit/Shared/RTCNetwork.cpp:
(WebKit::RTCNetwork::RTCNetwork):
(WebKit::RTCNetwork::value const):
(WebKit::ips): Deleted.
(WebKit::RTCNetwork::decode): Deleted.
(WebKit::RTCNetwork::encode const): Deleted.
* Source/WebKit/Shared/RTCNetwork.h:
* Source/WebKit/Shared/RTCNetwork.serialization.in:
* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.cpp:
(WebKit::LibWebRTCNetworkManager::networksChanged):

Canonical link: https://commits.webkit.org/269498@main




More information about the webkit-changes mailing list