[webkit-changes] [WebKit/WebKit] 4a0ec7: [JSC][armv7] Use udf for break/breakpoint in offli...

jjgriego noreply at github.com
Wed Oct 18 12:05:29 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4a0ec7daa9e9eb684bd61be24d35962f1263fd35
      https://github.com/WebKit/WebKit/commit/4a0ec7daa9e9eb684bd61be24d35962f1263fd35
  Author: Joseph Griego <jgriego at igalia.com>
  Date:   2023-10-18 (Wed, 18 Oct 2023)

  Changed paths:
    M Source/JavaScriptCore/assembler/ARMv7Assembler.h
    M Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h
    M Source/JavaScriptCore/llint/LowLevelInterpreter.asm
    M Source/JavaScriptCore/offlineasm/arm.rb

  Log Message:
  -----------
  [JSC][armv7] Use udf for break/breakpoint in offlineasm/masm
https://bugs.webkit.org/show_bug.cgi?id=263322

Reviewed by Yusuke Suzuki.

`bkpt` behaves very badly under gdb on armv7; it hangs [1] rather than traps.

To workaround, use `udf #0` instead; the encodings and semantics are very
similar.

[1] https://sourceware.org/bugzilla/show_bug.cgi?id=22645

* Source/JavaScriptCore/assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::udf):
* Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::breakpoint):
* Source/JavaScriptCore/offlineasm/arm.rb:

Canonical link: https://commits.webkit.org/269481@main




More information about the webkit-changes mailing list