[webkit-changes] [WebKit/WebKit] 31ae97: [CSS] Invalid @property rule should be ignored at ...

[Matthieu Dubet]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 31ae9755adc7c64da938e59c0c1eacc52d5636c7
      https://github.com/WebKit/WebKit/commit/31ae9755adc7c64da938e59c0c1eacc52d5636c7
  Author: Matthieu Dubet <m_dubet at apple.com>
  Date:   2023-10-18 (Wed, 18 Oct 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-cssom-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-cssom.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property.html
    M Source/WebCore/css/parser/CSSParserImpl.cpp
    M Source/WebCore/style/CustomPropertyRegistry.cpp

  Log Message:
  -----------
  [CSS] Invalid @property rule should be ignored at parse-time
https://bugs.webkit.org/show_bug.cgi?id=263007
rdar://116803886

Reviewed by Antti Koivisto and Tim Nguyen.

This patch moves most of the validity checks from rule-registration-time (during rule set building)
to parse-time, thus preventing invalid @property rules to appear in the CSSOM.

* LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-cssom-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-cssom.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property.html:
* Source/WebCore/css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::consumePropertyRule):
* Source/WebCore/style/CustomPropertyRegistry.cpp:
(WebCore::Style::CustomPropertyRegistry::registerFromStylesheet):

Canonical link: https://commits.webkit.org/269466@main