[webkit-changes] [WebKit/WebKit] dce93e: Adopt more smart pointers in the Element class

Chris Dumez noreply at github.com
Tue Oct 17 23:24:45 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dce93e1455ea9430b1385ffe812a7f19d7e23cfc
      https://github.com/WebKit/WebKit/commit/dce93e1455ea9430b1385ffe812a7f19d7e23cfc
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-10-17 (Tue, 17 Oct 2023)

  Changed paths:
    M Source/WebCore/dom/ContainerNode.h
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/Element.h
    M Source/WebCore/page/LocalFrame.h
    M Source/WebCore/page/LocalFrameView.h
    M Source/WebCore/rendering/RenderElement.h
    M Source/WebCore/rendering/RenderListBox.h
    M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
    M Source/WebKitLegacy/mac/DOM/DOMElement.mm

  Log Message:
  -----------
  Adopt more smart pointers in the Element class
https://bugs.webkit.org/show_bug.cgi?id=263271

Reviewed by Ryosuke Niwa.

* Source/WebCore/dom/ContainerNode.h:
* Source/WebCore/dom/Element.cpp:
(WebCore::attrNodeListMap):
(WebCore::attrNodeListForElement):
(WebCore::ensureAttrNodeListForElement):
(WebCore::removeAttrNodeListForElement):
(WebCore::shouldAutofocus):
(WebCore::elementIdentifiersMap):
(WebCore::Element::~Element):
(WebCore::Element::isKeyboardFocusable const):
(WebCore::dispatchPointerEventIfNeeded):
(WebCore::Element::dispatchMouseEvent):
(WebCore::Element::dispatchWheelEvent):
(WebCore::Element::dispatchKeyEvent):
(WebCore::Element::cloneShadowTreeIfPossible):
(WebCore::Element::cloneElementWithChildren):
(WebCore::Element::cloneElementWithoutChildren):
(WebCore::Element::detachAttribute):
(WebCore::Element::isUserActionElementInActiveChain const):
(WebCore::Element::isUserActionElementActive const):
(WebCore::Element::isUserActionElementFocused const):
(WebCore::Element::isUserActionElementHovered const):
(WebCore::Element::isUserActionElementDragged const):
(WebCore::Element::isUserActionElementHasFocusVisible const):
(WebCore::Element::isUserActionElementHasFocusWithin const):
(WebCore::Element::setActive):
(WebCore::Element::setFocus):
(WebCore::Element::setHasFocusVisible):
(WebCore::Element::setHasFocusWithin):
(WebCore::Element::setHasTentativeFocus):
(WebCore::Element::setHovered):
(WebCore::Element::setBeingDragged):
(WebCore::listBoxElementScrollIntoView):
(WebCore::Element::scrollIntoView):
(WebCore::Element::scrollIntoViewIfNeeded):
(WebCore::Element::scrollIntoViewIfNotVisible):
(WebCore::Element::scrollTo):
(WebCore::Element::scrollByUnits):
(WebCore::localZoomForRenderer):
(WebCore::Element::offsetLeft):
(WebCore::Element::offsetTop):
(WebCore::Element::offsetWidth):
(WebCore::Element::offsetHeight):
(WebCore::Element::offsetParentForBindings):
(WebCore::Element::offsetParent):
(WebCore::Element::clientLeft):
(WebCore::Element::clientTop):
(WebCore::Element::clientWidth):
(WebCore::Element::clientHeight):
(WebCore::Element::scrollLeft):
(WebCore::Element::scrollTop):
(WebCore::Element::setScrollLeft):
(WebCore::Element::setScrollTop):
(WebCore::Element::scrollWidth):
(WebCore::Element::scrollHeight):
(WebCore::shouldObtainBoundsFromSVGModel):
(WebCore::Element::boundsInRootViewSpace):
(WebCore::Element::boundingBoxInRootViewCoordinates const):
(WebCore::layoutOverflowRectContainsAllDescendants):
(WebCore::Element::absoluteEventBounds):
(WebCore::Element::absoluteEventBoundsOfElementAndDescendants):
(WebCore::Element::absoluteEventHandlerBounds):
(WebCore::listBoxElementBoundingBox):
(WebCore::Element::getClientRects):
(WebCore::Element::boundingAbsoluteRectWithoutLayout const):
(WebCore::Element::boundingClientRect):
(WebCore::Element::screenRect const):
(WebCore::Element::notifyAttributeChanged):
(WebCore::Element::attributeChanged):
(WebCore::Element::updateEffectiveLangStateAndPropagateToDescendants):
(WebCore::Element::setElementAttribute):
(WebCore::Element::setElementsArrayAttribute):
(WebCore::Element::allowsDoubleTapGesture const):
(WebCore::invalidateForSiblingCombinators):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::updateEffectiveLangStateFromParent):
(WebCore::Element::updateEffectiveLangState):
(WebCore::Element::insertedIntoAncestor):
(WebCore::Element::clearEffectiveLangStateOnNewDocumentElement):
(WebCore::Element::removedFromAncestor):
(WebCore::Element::addShadowRoot):
(WebCore::canAttachAuthorShadowRoot):
(WebCore::Element::shadowRootForBindings const):
(WebCore::Element::ensureUserAgentShadowRoot):
(WebCore::Element::createUserAgentShadowRoot):
(WebCore::Element::childrenChanged):
(WebCore::Element::removeAllEventListeners):
(WebCore::Element::setAttributeNode):
(WebCore::Element::setAttributeNodeNS):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::shadowRootWithDelegatesFocus):
(WebCore::autoFocusDelegate):
(WebCore::Element::findFocusDelegateForTarget):
(WebCore::Element::focus):
(WebCore::Element::findTargetAndUpdateFocusAppearance):
(WebCore::Element::blur):
(WebCore::Element::dispatchFocusInEventIfNeeded):
(WebCore::Element::dispatchFocusOutEventIfNeeded):
(WebCore::Element::dispatchFocusEvent):
(WebCore::Element::dispatchBlurEvent):
(WebCore::Element::dispatchMouseForceWillBegin):
(WebCore::Element::enqueueSecurityPolicyViolationEvent):
(WebCore::Element::mergeWithNextTextNode):
(WebCore::Element::setOuterHTML):
(WebCore::Element::setInnerHTML):
(WebCore::Element::innerText):
(WebCore::Element::willBecomeFullscreenElement):
(WebCore::forEachRenderLayer):
(WebCore::Element::addToTopLayer):
(WebCore::Element::removeFromTopLayer):
(WebCore::Element::resolveComputedStyle):
(WebCore::Element::resolvePseudoElementStyle):
(WebCore::Element::computedStyle):
(WebCore::Element::locale const):
(WebCore::Element::requestFullscreen):
(WebCore::Element::setPointerCapture):
(WebCore::Element::releasePointerCapture):
(WebCore::Element::hasPointerCapture):
(WebCore::Element::requestPointerLock):
(WebCore::Element::resetComputedStyle):
(WebCore::Element::clearHoverAndActiveStatusBeforeDetachingRenderer):
(WebCore::contextElementForInsertion):
(WebCore::Element::findAnchorElementForLink):
(WebCore::Element::animate):
(WebCore::Element::getAnimations):
(WebCore::Element::identifier const):
(WebCore::Element::fromIdentifier):
* Source/WebCore/dom/Element.h:
* Source/WebCore/page/LocalFrame.h:
* Source/WebCore/page/LocalFrameView.h:
(WebCore::LocalFrame::protectedView const):
* Source/WebCore/rendering/RenderElement.h:
(WebCore::ContainerNode::checkedRenderer const):
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::updateMainVideoElement):

Canonical link: https://commits.webkit.org/269449@main




More information about the webkit-changes mailing list