[webkit-changes] [WebKit/WebKit] f6e862: [IFC] Leading trimmable whitespace should not bloc...

Alan Baradlay noreply at github.com
Tue Oct 17 14:03:31 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f6e862621de841b2798770a742113887bca279ef
      https://github.com/WebKit/WebKit/commit/f6e862621de841b2798770a742113887bca279ef
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-10-17 (Tue, 17 Oct 2023)

  Changed paths:
    A LayoutTests/fast/text/zero-font-size-on-first-line-with-leading-whitespace-expected.html
    A LayoutTests/fast/text/zero-font-size-on-first-line-with-leading-whitespace.html
    M Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp

  Log Message:
  -----------
  [IFC] Leading trimmable whitespace should not block placing subsequent content on current line
https://bugs.webkit.org/show_bug.cgi?id=263205

Reviewed by Antti Koivisto.

ContinuousContent::hasTrimmableContent returns false when the trimmable content has zero width (font-size: 0px)
It prevents us from recognizing that the candidate content is fully trimmable and other content may still be placed on the current line.

* Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:
(WebCore::Layout::InlineContentBreaker::processOverflowingContent const):
* Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.h:
(WebCore::Layout::InlineContentBreaker::ContinuousContent::hasTrimmableSpace const):
(WebCore::Layout::InlineContentBreaker::ContinuousContent::hasHangingSpace const):
(WebCore::Layout::InlineContentBreaker::ContinuousContent::hasTrimmableContent const): Deleted.
(WebCore::Layout::InlineContentBreaker::ContinuousContent::hasHangingContent const): Deleted.

Canonical link: https://commits.webkit.org/269427@main




More information about the webkit-changes mailing list