[webkit-changes] [WebKit/WebKit] 5df7cd: Add support for `showPicker()` to `HTMLSelectElement`

Luke Warlow noreply at github.com
Tue Oct 17 11:43:22 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5df7cdc4a1ec1cfef6b892665536af6eefe925e2
      https://github.com/WebKit/WebKit/commit/5df7cdc4a1ec1cfef6b892665536af6eefe925e2
  Author: Luke Warlow <luke at warlow.dev>
  Date:   2023-10-17 (Tue, 17 Oct 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    A LayoutTests/fast/forms/select/select-show-picker-expected.txt
    A LayoutTests/fast/forms/select/select-show-picker.html
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-cross-origin-iframe.tentative-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-disabled.tentative-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-multiple.tentative-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-size.tentative-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-user-gesture.tentative-expected.txt
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/html/HTMLSelectElement.cpp
    M Source/WebCore/html/HTMLSelectElement.h
    M Source/WebCore/html/HTMLSelectElement.idl

  Log Message:
  -----------
  Add support for `showPicker()` to `HTMLSelectElement`
https://bugs.webkit.org/show_bug.cgi?id=261814

Reviewed by Aditya Keerthi.

At whatwg/html#9754, it's proposed to add a
new HTMLSelectElement::showPicker() method to show the popup for
select elements.

This patch introduces this functionality, for non-iOS platforms in WK2.

* LayoutTests/fast/forms/select/select-show-picker-expected.txt: Added.
* LayoutTests/fast/forms/select/select-show-picker.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-cross-origin-iframe.tentative-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-disabled.tentative-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-multiple.tentative-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-size.tentative-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-user-gesture.tentative-expected.txt: Added.
* LayoutTests/platform/ios/TestExpectations:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::showPicker):
* Source/WebCore/html/HTMLSelectElement.h:
* Source/WebCore/html/HTMLSelectElement.idl:
* LayoutTests/TestExpectations:
* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/269420@main




More information about the webkit-changes mailing list