[webkit-changes] [WebKit/WebKit] ea2c36: An SVG element with a CSS reference filter fails t...

Simon Fraser noreply at github.com
Tue Oct 17 10:29:29 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ea2c363617419ea80c547fa4f2b1d645e619301e
      https://github.com/WebKit/WebKit/commit/ea2c363617419ea80c547fa4f2b1d645e619301e
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2023-10-17 (Tue, 17 Oct 2023)

  Changed paths:
    A LayoutTests/svg/filters/css-repaint-reference-filter-on-root-expected.txt
    A LayoutTests/svg/filters/css-repaint-reference-filter-on-root.html
    M Source/WebCore/rendering/RenderLayer.cpp

  Log Message:
  -----------
  An SVG element with a CSS reference filter fails to repaint when the filter changes
https://bugs.webkit.org/show_bug.cgi?id=263229
rdar://117047658

Reviewed by Nikolas Zimmermann.

If an SVG element has a CSS filter which references an SVG element (which may be a child of that SVG,
or some other SVG in the document), then we fail to repaint the SVG when the filter changes.

This is a followup to 267236 at main, removing the `&& !renderer().isSVGRootOrLegacySVGRoot()` check in
`RenderLayer::updateFiltersAfterStyleChange()`, since in this configuration we do need to have
the RenderLayer track the filter dependencies.

* LayoutTests/svg/filters/css-repaint-reference-filter-on-root-expected.txt: Added.
* LayoutTests/svg/filters/css-repaint-reference-filter-on-root.html: Added.
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateFiltersAfterStyleChange):

Canonical link: https://commits.webkit.org/269413@main




More information about the webkit-changes mailing list