[webkit-changes] [WebKit/WebKit] a983bc: [WGSL] Remove stale or unhelpful fixmes
Tadeu Zagallo
noreply at github.com
Tue Oct 17 09:11:24 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a983bc7f77aa2c12b7633c8209928b9a94104b82
https://github.com/WebKit/WebKit/commit/a983bc7f77aa2c12b7633c8209928b9a94104b82
Author: Tadeu Zagallo <tzagallo at apple.com>
Date: 2023-10-17 (Tue, 17 Oct 2023)
Changed paths:
M Source/WebGPU/WGSL/AST/ASTVariableQualifier.h
M Source/WebGPU/WGSL/MangleNames.cpp
M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
M Source/WebGPU/WGSL/Parser.cpp
M Source/WebGPU/WGSL/Token.h
M Source/WebGPU/WGSL/TypeCheck.cpp
M Source/WebGPU/WGSL/WGSL.cpp
M Source/WebGPU/WGSL/tests/valid/name-mangling.wgsl
M Source/WebGPU/WGSL/tests/valid/overload.wgsl
Log Message:
-----------
[WGSL] Remove stale or unhelpful fixmes
https://bugs.webkit.org/show_bug.cgi?id=263228
rdar://117047230
Reviewed by Dan Glastonbury.
Remove FIXMEs that were forgotten or that are no longer relevant.
* Source/WebGPU/WGSL/AST/ASTVariableQualifier.h:
* Source/WebGPU/WGSL/MangleNames.cpp:
(WGSL::NameManglerVisitor::readVariable const):
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser<Lexer>::parseAttribute):
(WGSL::Parser<Lexer>::parseAddressSpace):
(WGSL::Parser<Lexer>::parsePostfixExpression):
(WGSL::Parser<Lexer>::parsePrimaryExpression):
(WGSL::Parser<Lexer>::parseExpression):
* Source/WebGPU/WGSL/Token.h:
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::check):
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/WGSL.cpp:
(WGSL::staticCheck):
* Source/WebGPU/WGSL/tests/valid/name-mangling.wgsl:
* Source/WebGPU/WGSL/tests/valid/overload.wgsl:
Canonical link: https://commits.webkit.org/269410@main
More information about the webkit-changes
mailing list