[webkit-changes] [WebKit/WebKit] 236dd9: SVGResourcesCache::addResourcesFromRenderObject sh...

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 236dd9dd2c2c2cf873fc7de8d3d15bd685176724
      https://github.com/WebKit/WebKit/commit/236dd9dd2c2c2cf873fc7de8d3d15bd685176724
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
    M Source/WebCore/rendering/svg/SVGResources.cpp
    M Source/WebCore/rendering/svg/SVGResources.h
    M Source/WebCore/rendering/svg/SVGResourcesCache.cpp

  Log Message:
  -----------
  SVGResourcesCache::addResourcesFromRenderObject should not allocate SVGResources unconditionally
https://bugs.webkit.org/show_bug.cgi?id=98684

Reviewed by Nikolas Zimmermann.

Only allocate SVGResources where needed and possible (not pending).

* Source/WebCore/rendering/svg/SVGResources.cpp:
(WebCore::SVGResources::buildCachedResources):
(WebCore::SVGResources::setClipper):
(WebCore::SVGResources::setFilter):
(WebCore::SVGResources::setMarkerStart):
(WebCore::SVGResources::setMarkerMid):
(WebCore::SVGResources::setMarkerEnd):
(WebCore::SVGResources::setMasker):
(WebCore::SVGResources::setFill):
(WebCore::SVGResources::setStroke):
(WebCore::SVGResources::setLinkedResource):
* Source/WebCore/rendering/svg/SVGResources.h:
* Source/WebCore/rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::addResourcesFromRenderer):

Canonical link: https://commits.webkit.org/269397@main