[webkit-changes] [WebKit/WebKit] 39451b: Eliminate Test Code to crash a WebKit XPC service

Michael Saboff noreply at github.com
Mon Oct 16 19:44:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 39451bfc5712f354d2ecf713c24de4d5f1336165
      https://github.com/WebKit/WebKit/commit/39451bfc5712f354d2ecf713c24de4d5f1336165
  Author: Michael Saboff <msaboff at apple.com>
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
    M Source/WTF/wtf/PlatformEnableCocoa.h
    R Source/WebKit/Configurations/WebContentCrashyExtension.xcconfig
    R Source/WebKit/Configurations/WebContentService.Crashy.xcconfig
    M Source/WebKit/Configurations/WebContentService.xcconfig
    M Source/WebKit/Scripts/process-entitlements.sh
    R Source/WebKit/Shared/AuxiliaryProcessExtensions/WebContentExtension-Crashy-Info.plist
    M Source/WebKit/Shared/AuxiliaryProcessExtensions/com.apple.WebKit.appexpt
    M Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm
    M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
    M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm
    M Source/WebKit/UIProcess/WebProcessPool.cpp
    M Source/WebKit/UIProcess/WebProcessPool.h
    M Source/WebKit/UIProcess/WebProcessProxy.cpp
    M Source/WebKit/UIProcess/WebProcessProxy.h
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

  Log Message:
  -----------
  Eliminate Test Code to crash a WebKit XPC service
https://bugs.webkit.org/show_bug.cgi?id=263045
rdar://115678493

Reviewed by Timothy Hatcher and Alex Christensen.

Remove WebContent.Crashy XPC process as it has served its purpose and is no longer needed.

* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WebKit/Configurations/WebContentCrashyExtension.xcconfig: Removed.
* Source/WebKit/Configurations/WebContentService.Crashy.xcconfig: Removed.
* Source/WebKit/Configurations/WebContentService.xcconfig:
* Source/WebKit/Scripts/process-entitlements.sh:
* Source/WebKit/Shared/AuxiliaryProcessExtensions/WebContentExtension-Crashy-Info.plist: Removed.
* Source/WebKit/Shared/AuxiliaryProcessExtensions/com.apple.WebKit.appexpt:
* Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:
(WebKit::XPCServiceInitializerDelegate::getExtraInitializationData):
* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitialize):
(isInternalBuild): Deleted.
(canaryInBaseState): Deleted.
(WebKit::WebProcessPool::initializeShouldCrashWhenCreatingWebProcess): Deleted.
* Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
(WebKit::webContentServiceName):
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createNewWebProcess):
(WebKit::WebProcessPool::forEachProcessForSession):
* Source/WebKit/UIProcess/WebProcessPool.h:
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getLaunchOptions):
(WebKit::WebProcessProxy::createForWebContentCrashy): Deleted.
* Source/WebKit/UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::isCrashyProcess const): Deleted.
(WebKit::WebProcessProxy::setIsCrashyProcess): Deleted.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeProcess):
(WebKit::deliberateCrashForTesting): Deleted.

Canonical link: https://commits.webkit.org/269395@main




More information about the webkit-changes mailing list