[webkit-changes] [WebKit/WebKit] 9320b5: (REGRESSION (265731 at main): fast/scrolling/rtl-scro...

Nikos Mouchtaris noreply at github.com
Mon Oct 16 17:13:28 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9320b50206384e7b857c586879952789b6d16aaf
      https://github.com/WebKit/WebKit/commit/9320b50206384e7b857c586879952789b6d16aaf
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
    M Source/WebCore/platform/mac/ScrollbarThemeMac.mm

  Log Message:
  -----------
  (REGRESSION (265731 at main): fast/scrolling/rtl-scrollbars-animation-property.html is a constant failure)
https://bugs.webkit.org/show_bug.cgi?id=262930
rdar://114349934

Reviewed by Cameron McCormack.

After https://commits.webkit.org/265731@main ScrollbarThemeMac::isLayoutDirectionRTL did not have an
NSScrollerImp to query about being in rtl mode. AppKit only uses userInterfaceLayoutDirection for
rectForPart/expandedRectForPart, which are not used with UI-side compositing, so for now if we detect
that the scrollbar should not be registered (due to UI-side compositing being on), just query the scrollable
area to see if the scrollbar is in rtl mode.

* Source/WebCore/platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::isLayoutDirectionRTL):

Canonical link: https://commits.webkit.org/269390@main




More information about the webkit-changes mailing list