[webkit-changes] [WebKit/WebKit] 100c20: Adopt even more smart pointers in the DOM

Chris Dumez noreply at github.com
Mon Oct 16 13:53:12 PDT 2023 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 100c20fadc5e59baa58f342cec29e7b9dff3c1e5
      https://github.com/WebKit/WebKit/commit/100c20fadc5e59baa58f342cec29e7b9dff3c1e5
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-10-16 (Mon, 16 Oct 2023)

  Changed paths:
    M Source/WTF/wtf/Ref.h
    M Source/WebCore/Headers.cmake
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
    M Source/WebCore/accessibility/AccessibilityNodeObject.h
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
    M Source/WebCore/bindings/js/JSDOMWindowProperties.cpp
    M Source/WebCore/css/StyleSheetList.cpp
    M Source/WebCore/dom/CustomElementDefaultARIA.cpp
    M Source/WebCore/dom/CustomElementDefaultARIA.h
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/DocumentFragment.cpp
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/Element.h
    M Source/WebCore/dom/ElementInternals.cpp
    M Source/WebCore/dom/ElementInternals.h
    M Source/WebCore/dom/ImageOverlay.cpp
    M Source/WebCore/dom/Node.cpp
    M Source/WebCore/dom/SelectorQuery.cpp
    M Source/WebCore/dom/TreeScope.cpp
    M Source/WebCore/dom/TreeScope.h
    A Source/WebCore/dom/TreeScopeInlines.h
    M Source/WebCore/dom/TreeScopeOrderedMap.cpp
    M Source/WebCore/dom/TreeScopeOrderedMap.h
    M Source/WebCore/dom/TreeWalker.cpp
    M Source/WebCore/dom/UserGestureIndicator.cpp
    M Source/WebCore/dom/VisitedLinkState.cpp
    M Source/WebCore/dom/mac/ImageControlsMac.cpp
    M Source/WebCore/html/CachedHTMLCollectionInlines.h
    M Source/WebCore/html/HTMLAreaElement.cpp
    M Source/WebCore/html/HTMLAreaElement.h
    M Source/WebCore/html/HTMLCollection.cpp
    M Source/WebCore/html/HTMLCollection.h
    M Source/WebCore/html/HTMLCollectionInlines.h
    M Source/WebCore/html/HTMLDocument.h
    M Source/WebCore/html/HTMLFormControlElement.cpp
    M Source/WebCore/html/HTMLFormControlElement.h
    M Source/WebCore/html/HTMLImageElement.cpp
    M Source/WebCore/html/HTMLImageElement.h
    M Source/WebCore/html/HTMLMapElement.cpp
    M Source/WebCore/html/HTMLMapElement.h
    M Source/WebCore/inspector/InspectorAuditAccessibilityObject.cpp
    M Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
    M Source/WebCore/page/FocusController.cpp
    M Source/WebCore/page/PrintContext.cpp
    M Source/WebCore/page/Quirks.cpp
    M Source/WebCore/page/SpatialNavigation.cpp
    M Source/WebCore/rendering/CSSFilter.cpp
    M Source/WebCore/rendering/ReferencedSVGResources.cpp
    M Source/WebCore/rendering/ReferencedSVGResources.h
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderImage.cpp
    M Source/WebCore/rendering/RenderImage.h
    M Source/WebCore/rendering/RenderLayerFilters.cpp
    M Source/WebCore/rendering/RenderObject.cpp
    M Source/WebCore/style/StyleAdjuster.cpp
    M Source/WebCore/svg/SVGSVGElement.cpp
    M Source/WebCore/svg/SVGSVGElement.h
    M Source/WebCore/svg/SVGViewSpec.cpp
    M Source/WebCore/svg/SVGViewSpec.h
    M Source/WebCore/svg/animation/SVGSMILElement.cpp
    M Source/WebCore/svg/animation/SVGSMILElement.h
    M Source/WebCore/xml/XPathFunctions.cpp
    M Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp

  Log Message:
  -----------
  Adopt even more smart pointers in the DOM
https://bugs.webkit.org/show_bug.cgi?id=263171

Reviewed by Darin Adler and Ryosuke Niwa.

* Source/WTF/wtf/Ref.h:
Remove dead declarations (without implementation) which caused linking errors
as I was working on this.

* Source/WebCore/Headers.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::focusedImageMapUIElement):
(WebCore::AXObjectCache::addRelations):
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::labelsForNode):
(WebCore::AccessibilityNodeObject::popoverTargetElement const):
(WebCore::AccessibilityNodeObject::textUnderElement const):
(WebCore::AccessibilityNodeObject::descriptionForElements const):
(WebCore::AccessibilityNodeObject::ariaLabeledByElements const):
(WebCore:: const): Deleted.
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isTabItemSelected const):
(WebCore::AccessibilityObject::isExpanded const):
(WebCore::AccessibilityObject::elementsFromAttribute const):
(WebCore:: const): Deleted.
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::popoverTargetElement const):
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityParentForImageMap const):
(WebCore::AccessibilityRenderObject::documentLinks):
* Source/WebCore/bindings/js/JSDOMWindowProperties.cpp:
(WebCore::jsDOMWindowPropertiesGetOwnPropertySlotNamedItemGetter):
* Source/WebCore/css/StyleSheetList.cpp:
(WebCore::StyleSheetList::namedItem const):
* Source/WebCore/dom/CustomElementDefaultARIA.cpp:
(WebCore::CustomElementDefaultARIA::elementForAttribute const):
* Source/WebCore/dom/CustomElementDefaultARIA.h:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::handlePopoverLightDismiss):
* Source/WebCore/dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::getElementById const):
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::getElementAttribute const):
(WebCore::Element::getElementsArrayAttribute const):
* Source/WebCore/dom/Element.h:
* Source/WebCore/dom/ElementInternals.cpp:
(WebCore::ElementInternals::getElementAttribute const):
* Source/WebCore/dom/ElementInternals.h:
* Source/WebCore/dom/ImageOverlay.cpp:
* Source/WebCore/dom/Node.cpp:
(WebCore::Node::renderRect):
* Source/WebCore/dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::executeFastPathForIdSelector const):
(WebCore::filterRootById):
* Source/WebCore/dom/TreeScope.cpp:
(WebCore::TreeScope::getElementById const):
(WebCore::TreeScope::getAllElementsById const):
(WebCore::TreeScope::getElementByName const):
(WebCore::TreeScope::getImageMap const):
(WebCore::TreeScope::imageElementByUsemap const):
(WebCore::TreeScope::labelElementsForId):
(WebCore::TreeScope::findAnchor):
(WebCore:: const): Deleted.
(): Deleted.
* Source/WebCore/dom/TreeScope.h:
(WebCore::TreeScope::hasElementWithId const): Deleted.
(WebCore::TreeScope::containsMultipleElementsWithId const): Deleted.
(WebCore::TreeScope::hasElementWithName const): Deleted.
(WebCore::TreeScope::containsMultipleElementsWithName const): Deleted.
* Source/WebCore/dom/TreeScopeInlines.h: Added.
(WebCore::TreeScope::hasElementWithId const):
(WebCore::TreeScope::containsMultipleElementsWithId const):
(WebCore::TreeScope::hasElementWithName const):
(WebCore::TreeScope::containsMultipleElementsWithName const):
* Source/WebCore/dom/TreeScopeOrderedMap.cpp:
(WebCore::TreeScopeOrderedMap::get const):
(WebCore::TreeScopeOrderedMap::getAll const):
(WebCore::TreeScopeOrderedMap::getElementById const):
(WebCore::TreeScopeOrderedMap::getElementByName const):
(WebCore::TreeScopeOrderedMap::getElementByMapName const):
(WebCore::TreeScopeOrderedMap::getElementByUsemap const):
(WebCore::TreeScopeOrderedMap::getElementsByLabelForAttribute const):
(WebCore::TreeScopeOrderedMap::getElementByWindowNamedItem const):
(WebCore::TreeScopeOrderedMap::getElementByDocumentNamedItem const):
(WebCore::TreeScopeOrderedMap::getAllElementsById const):
(WebCore:: const): Deleted.
* Source/WebCore/dom/TreeScopeOrderedMap.h:
* Source/WebCore/dom/TreeWalker.cpp:
* Source/WebCore/dom/UserGestureIndicator.cpp:
(WebCore::UserGestureToken::UserGestureToken):
* Source/WebCore/dom/VisitedLinkState.cpp:
(WebCore::VisitedLinkState::invalidateStyleForAllLinks):
(WebCore::VisitedLinkState::invalidateStyleForLink):
(WebCore::VisitedLinkState::determineLinkStateSlowCase):
* Source/WebCore/dom/mac/ImageControlsMac.cpp:
* Source/WebCore/html/CachedHTMLCollectionInlines.h:
(WebCore::traversalType>::namedItem const):
* Source/WebCore/html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::imageElement const):
(WebCore::HTMLAreaElement::isFocusable const):
(WebCore::HTMLAreaElement::setFocus):
* Source/WebCore/html/HTMLAreaElement.h:
* Source/WebCore/html/HTMLCollection.cpp:
(WebCore::HTMLCollection::namedItemSlow const):
(WebCore::HTMLCollection::namedItems const):
* Source/WebCore/html/HTMLCollection.h:
* Source/WebCore/html/HTMLCollectionInlines.h:
(WebCore::CollectionNamedElementCache::findElementsWithId const):
(WebCore::CollectionNamedElementCache::findElementsWithName const):
(WebCore::CollectionNamedElementCache::find const):
(WebCore::CollectionNamedElementCache::append):
(WebCore:: const): Deleted.
* Source/WebCore/html/HTMLDocument.h:
(WebCore::HTMLDocument::documentNamedItem const):
(WebCore::HTMLDocument::windowNamedItem const):
* Source/WebCore/html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::popoverTargetElement const):
* Source/WebCore/html/HTMLFormControlElement.h:
* Source/WebCore/html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::associatedMapElement const):
* Source/WebCore/html/HTMLImageElement.h:
* Source/WebCore/html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement):
* Source/WebCore/html/HTMLMapElement.h:
* Source/WebCore/inspector/InspectorAuditAccessibilityObject.cpp:
(WebCore::InspectorAuditAccessibilityObject::getControlledNodes):
(WebCore::InspectorAuditAccessibilityObject::getFlowedNodes):
(WebCore::InspectorAuditAccessibilityObject::getOwnedNodes):
* Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
* Source/WebCore/page/FocusController.cpp:
(WebCore::invokerForPopoverShowingState):
(WebCore::FocusNavigationScope::scopeOwnedByPopoverInvoker):
(WebCore::FocusController::advanceFocusDirectionally):
* Source/WebCore/page/SpatialNavigation.cpp:
(WebCore::FocusCandidate::FocusCandidate):
* Source/WebCore/rendering/CSSFilter.cpp:
(WebCore::referenceFilterElement):
(WebCore::isIdentityReferenceFilter):
(WebCore::calculateReferenceFilterOutsets):
(WebCore::createReferenceFilter):
* Source/WebCore/rendering/ReferencedSVGResources.cpp:
(WebCore::ReferencedSVGResources::removeClientForTarget):
(WebCore::ReferencedSVGResources::updateReferencedResources):
(WebCore::ReferencedSVGResources::elementForResourceID):
(WebCore::ReferencedSVGResources::referencedFilterElement):
* Source/WebCore/rendering/ReferencedSVGResources.h:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::hitTestClipPath const):
* Source/WebCore/rendering/RenderImage.cpp:
(WebCore::RenderImage::imageMap const):
(WebCore::RenderImage::nodeAtPoint):
* Source/WebCore/rendering/RenderImage.h:
* Source/WebCore/rendering/RenderLayerFilters.cpp:
(WebCore::RenderLayerFilters::updateReferenceFilterClients):
* Source/WebCore/style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjustForSiteSpecificQuirks const):
* Source/WebCore/svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::getElementById):
* Source/WebCore/svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::viewTarget const):
* Source/WebCore/svg/SVGViewSpec.h:
* Source/WebCore/svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::eventBaseFor):
* Source/WebCore/svg/animation/SVGSMILElement.h:
* Source/WebCore/xml/XPathFunctions.cpp:
(WebCore::XPath::FunId::evaluate const):
* Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::pageNumberForElementById):

Canonical link: https://commits.webkit.org/269380@main

More information about the webkit-changes mailing list