[webkit-changes] [WebKit/WebKit] a971ac: REGRESSION(268342 at main): Web process crashes when ...

Charlie Wolfe noreply at github.com
Sat Oct 14 15:52:15 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a971ac1032e7e561aa2388217733d3d117617a98
      https://github.com/WebKit/WebKit/commit/a971ac1032e7e561aa2388217733d3d117617a98
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2023-10-14 (Sat, 14 Oct 2023)

  Changed paths:
    A LayoutTests/http/tests/media/cross-origin-webm-video-expected.txt
    A LayoutTests/http/tests/media/cross-origin-webm-video.html
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm

  Log Message:
  -----------
  REGRESSION(268342 at main): Web process crashes when loading a cross-origin WebM resource
https://bugs.webkit.org/show_bug.cgi?id=263144
rdar://116894594

Reviewed by Pascoe.

WebM video requests currently always set the first party for cookies to its own URL, so our
allowsFirstPartyForCookies message check will fail when loading a cross origin video. The resource
loader will end up setting the correct first party for cookies if one is not already set, so let’s
just not set one here.

* LayoutTests/http/tests/media/cross-origin-webm-video-expected.txt: Added.
* LayoutTests/http/tests/media/cross-origin-webm-video.html: Added.
* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm:
(WebCore::MediaPlayerPrivateWebM::load):

Canonical link: https://commits.webkit.org/269345@main




More information about the webkit-changes mailing list