[webkit-changes] [WebKit/WebKit] a19a3b: Web Inspector: remove incorrect WebGPU support aft...

Devin Rousso noreply at github.com
Fri Oct 13 15:04:34 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a19a3bb3454c094054797db8c0279eedab4c2135
      https://github.com/WebKit/WebKit/commit/a19a3bb3454c094054797db8c0279eedab4c2135
  Author: Devin Rousso <hi at devinrousso.com>
  Date:   2023-10-13 (Fri, 13 Oct 2023)

  Changed paths:
    M Source/JavaScriptCore/inspector/protocol/Canvas.json
    M Source/WebCore/inspector/InspectorCanvas.cpp
    M Source/WebCore/inspector/agents/InspectorCanvasAgent.cpp

  Log Message:
  -----------
  Web Inspector: remove incorrect WebGPU support after 268693 at main
https://bugs.webkit.org/show_bug.cgi?id=263135

Reviewed by Mike Wyrzykowski.

Web Inspector does not currently support WebGPU (not counting compatibility support for older macOS/iOS).

Furthermore, previous WebGPU instrumentation focused on the `GPUDevice` rather than the `GPUCanvasContext` since a single `GPUDevice` could be used for multiple `GPUCanvasContext`.

There was already logic to ensure that only supported `<canvas>` were instrumented when created *after* Web Inspector was opened (though technically that logic was more "we only insert `InspectorInstrumentation` in the places we know we can support"), but the path for if it was created *before* Web Inspector is opened didn't have the same safeguards.

* Source/JavaScriptCore/inspector/protocol/Canvas.json:
* Source/WebCore/inspector/InspectorCanvas.cpp:
(WebCore::InspectorCanvas::buildObjectForCanvas):
* Source/WebCore/inspector/agents/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::internalEnable):

Canonical link: https://commits.webkit.org/269322@main




More information about the webkit-changes mailing list