[webkit-changes] [WebKit/WebKit] 5ce55c: AX: align AccessibilityRole::Switch with ::Checkbox

Anne van Kesteren noreply at github.com
Fri Oct 13 11:33:34 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5ce55c698227f6ac484867f0b741cb9b8c73f4c7
      https://github.com/WebKit/WebKit/commit/5ce55c698227f6ac484867f0b741cb9b8c73f4c7
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-10-13 (Fri, 13 Oct 2023)

  Changed paths:
    M LayoutTests/accessibility/aria-required-expected.txt
    M LayoutTests/accessibility/aria-required.html
    M LayoutTests/inspector/dom/getAccessibilityPropertiesForNode-expected.txt
    M LayoutTests/inspector/dom/getAccessibilityPropertiesForNode.html
    M LayoutTests/interaction-region/aria-roles-expected.txt
    M LayoutTests/interaction-region/aria-roles.html
    M LayoutTests/platform/gtk/inspector/dom/getAccessibilityPropertiesForNode-expected.txt
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
    M Source/WebCore/page/InteractionRegion.cpp

  Log Message:
  -----------
  AX: align AccessibilityRole::Switch with ::Checkbox
https://bugs.webkit.org/show_bug.cgi?id=263008
rdar://116805287

Reviewed by Tyler Wilcock.

A switch should essentially be a checkbox except that it doesn't
support the intermediate/mixed state.

As such, this makes the following changes:

- We make switch support the required attribute.
- We make interaction regions support switches.

* LayoutTests/accessibility/aria-required-expected.txt:
* LayoutTests/accessibility/aria-required.html:
* LayoutTests/inspector/dom/getAccessibilityPropertiesForNode-expected.txt:
* LayoutTests/inspector/dom/getAccessibilityPropertiesForNode.html:
* LayoutTests/interaction-region/aria-roles-expected.txt:
* LayoutTests/interaction-region/aria-roles.html:
* LayoutTests/platform/gtk/inspector/dom/getAccessibilityPropertiesForNode-expected.txt:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::supportsRequiredAttribute const):
* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::shouldAllowAccessibilityRoleAsPointerCursorReplacement):

Canonical link: https://commits.webkit.org/269311@main




More information about the webkit-changes mailing list