[webkit-changes] [WebKit/WebKit] bcd2ed: [PGO] Warn when PGO data appears to be an LFS stub

[Elliott Williams]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bcd2edf42d7fc9b709017808388bbb0424234880
      https://github.com/WebKit/WebKit/commit/bcd2edf42d7fc9b709017808388bbb0424234880
  Author: Elliott Williams <emw at apple.com>
  Date:   2023-10-12 (Thu, 12 Oct 2023)

  Changed paths:
    M Source/JavaScriptCore/Scripts/copy-profiling-data.sh

  Log Message:
  -----------
  [PGO] Warn when PGO data appears to be an LFS stub
https://bugs.webkit.org/show_bug.cgi?id=263087
rdar://113034512

Reviewed by Alexey Proskuryakov.

Check input PGO data's size; if it's < 1KB, assume it's invalid, and
likely an LFS stub indicating that the checkout is not set up to
download LFS objects. Print an diagnostic message accordingly.

Previously, we allowed decompression to fail in Debug/Release builds, so
that engineers who don't have LFS set up can build. Now that we check
for this case explicitly, require compression_tool to succeed.

* Source/JavaScriptCore/Scripts/copy-profiling-data.sh:

Canonical link: https://commits.webkit.org/269282@main