[webkit-changes] [WebKit/WebKit] 9ea929: Add <input type=checkbox switch> infrastructure

Anne van Kesteren noreply at github.com
Thu Oct 12 05:43:49 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9ea9298663a4c17a15be6c8eae83a67f8d345f9f
      https://github.com/WebKit/WebKit/commit/9ea9298663a4c17a15be6c8eae83a67f8d345f9f
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-10-12 (Thu, 12 Oct 2023)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
    M Source/WebCore/css/CSSPrimitiveValueMappings.h
    M Source/WebCore/en.lproj/Localizable.strings
    M Source/WebCore/html/CheckboxInputType.cpp
    M Source/WebCore/html/CheckboxInputType.h
    M Source/WebCore/html/HTMLAttributeNames.in
    M Source/WebCore/html/HTMLInputElement.cpp
    M Source/WebCore/html/HTMLInputElement.h
    M Source/WebCore/html/HTMLInputElement.idl
    M Source/WebCore/platform/LocalizedStrings.cpp
    M Source/WebCore/platform/LocalizedStrings.h
    M Source/WebCore/rendering/RenderTheme.cpp
    M Source/WebCore/style/StyleAppearance.cpp
    M Source/WebCore/style/StyleAppearance.h
    M Source/WebKit/Shared/WebCoreArgumentCoders.cpp
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm

  Log Message:
  -----------
  Add <input type=checkbox switch> infrastructure
https://bugs.webkit.org/show_bug.cgi?id=262966
rdar://116746765

Reviewed by Aditya Keerthi.

Adds the infrastructure needed to eventually be able to support an HTML
switch control. It notably does not cover any rendering aspects (except
for not rendering a checkbox).

This feature is documented in https://github.com/whatwg/html/pull/9546.

This builds on excellent prototyping work done by Lily Spiniolas.

This commit includes some fixes resulting from running
update-webkit-localizable-strings.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const):
(WebCore::AccessibilityNodeObject::checkboxOrRadioValue const):
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::toCSSValueID):
* Source/WebCore/en.lproj/Localizable.strings:
* Source/WebCore/html/CheckboxInputType.cpp:
(WebCore::CheckboxInputType::valueMissingText const):
(WebCore::CheckboxInputType::attributeChanged):
(WebCore::CheckboxInputType::shouldAppearIndeterminate const):
* Source/WebCore/html/CheckboxInputType.h:
* Source/WebCore/html/HTMLAttributeNames.in:
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isSwitch const):
* Source/WebCore/html/HTMLInputElement.h:
* Source/WebCore/html/HTMLInputElement.idl:
* Source/WebCore/platform/LocalizedStrings.cpp:
(WebCore::validationMessageValueMissingForCheckboxText):
(WebCore::validationMessageValueMissingForSwitchText):
* Source/WebCore/platform/LocalizedStrings.h:
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::autoAppearanceForElement const):
(WebCore::RenderTheme::createControlPart const):
* Source/WebCore/style/StyleAppearance.cpp:
(WebCore::operator<<):
* Source/WebCore/style/StyleAppearance.h:
* Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<ControlPart>::encode):
(IPC::ArgumentCoder<ControlPart>::decode):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView fullScreenWindowSceneDimmingAction]):

Canonical link: https://commits.webkit.org/269247@main




More information about the webkit-changes mailing list