[webkit-changes] [WebKit/WebKit] 5bf1af: Obtain Location from appropriate Window directly, ...

[sideshowbarker]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5bf1af1ceb7a05c6f0bfc2bf4c890c0bcade1c7a
      https://github.com/WebKit/WebKit/commit/5bf1af1ceb7a05c6f0bfc2bf4c890c0bcade1c7a
  Author: Michael[tm] Smith <mike at w3.org>
  Date:   2023-10-11 (Wed, 11 Oct 2023)

  Changed paths:
    M LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html
    M LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html
    M LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window3.html
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/back-forward-cache/pushstate.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/back-forward-cache/service-worker-clients-claim.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/back-forward-cache/service-worker-clients-matchall.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/back-forward-cache/service-worker-controlled-after-restore.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/back-forward-cache/service-worker-unregister.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/back-forward-cache/storage-events-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/navigate-cross-origin-iframe-to-same-url-with-fragment-fire-load-event-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/001-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/002-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/no_window_open_when_term_nesting_level_nonzero.window-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/bailout-exception-vs-return-xml.window-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/ignore-opens-during-unload.window-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/event-loops/fully_active_document.window-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/allow-crossorigin-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/disallow-crossorigin-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/promise-rejection-events-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/promise-rejection-events-iframe-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/webappapis/update-rendering/child-document-raf-order-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/webappapis/user-prompts/cannot-show-simple-dialogs/confirm-different-origin-frame.sub-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/webappapis/user-prompts/cannot-show-simple-dialogs/prompt-different-origin-frame.sub-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window-expected.txt
    M Source/WebCore/page/Location.cpp

  Log Message:
  -----------
  Obtain Location from appropriate Window directly, rather then Frame
https://bugs.webkit.org/show_bug.cgi?id=261889

Reviewed by Chris Dumez.

This change causes Location::url() to be obtained from the appropriate
Window instance directly, rather than a Frame.

Otherwise, without this change, the “document.open() does not change
document's URL (active but not fully active document)” test case from
https://wpt.fyi/results/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window.html
fails in WebKit, and a number of other tests time out unexpectedly.

Note: This change incidentally also corrects the expectations for the test at
https://wpt.fyi/results/html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/disallow-crossorigin.html
In its WebKit expectations file, that test been marked as a TIMEOUT —
but it’s marked as a FAIL in the wpt.fyi results.

* LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html:
* LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html:
* LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window3.html:
Adjusted expected location.href

* LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/back-forward-cache/pushstate.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/back-forward-cache/service-worker-clients-claim.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/back-forward-cache/service-worker-clients-matchall.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/back-forward-cache/service-worker-controlled-after-restore.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/back-forward-cache/service-worker-unregister.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/back-forward-cache/storage-events-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/navigate-cross-origin-iframe-to-same-url-with-fragment-fire-load-event-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/001-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/002-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/open-close/no_window_open_when_term_nesting_level_nonzero.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/bailout-exception-vs-return-xml.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/ignore-opens-during-unload.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/event-loops/fully_active_document.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/allow-crossorigin-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/disallow-crossorigin-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/promise-rejection-events-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/promise-rejection-events-iframe-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/webappapis/update-rendering/child-document-raf-order-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/webappapis/user-prompts/cannot-show-simple-dialogs/confirm-different-origin-frame.sub-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/webappapis/user-prompts/cannot-show-simple-dialogs/prompt-different-origin-frame.sub-expected.txt:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window-expected.txt:
* Source/WebCore/page/Location.cpp:
(WebCore::Location::url const):

Canonical link: https://commits.webkit.org/269235@main