[webkit-changes] [WebKit/WebKit] e7149c: Reduce use of Vector::uncheckedAppend() throughout...

Chris Dumez noreply at github.com
Wed Oct 11 15:14:30 PDT 2023 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e7149c4d7559e4b663d3f375be37dc5dba82c8ca
      https://github.com/WebKit/WebKit/commit/e7149c4d7559e4b663d3f375be37dc5dba82c8ca
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-10-11 (Wed, 11 Oct 2023)

  Changed paths:
    M Source/WTF/wtf/JSONValues.h
    M Source/WTF/wtf/URLParser.cpp
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp
    M Source/WebCore/contentextensions/ContentExtensionActions.cpp
    M Source/WebCore/contentextensions/ContentExtensionsBackend.cpp
    M Source/WebCore/contentextensions/DFABytecodeCompiler.cpp
    M Source/WebCore/contentextensions/DFAMinimizer.cpp
    M Source/WebCore/contentextensions/MutableRangeList.h
    M Source/WebCore/css/typedom/ComputedStylePropertyMapReadOnly.cpp
    M Source/WebCore/cssjit/SelectorCompiler.cpp
    M Source/WebCore/page/mac/ImageOverlayControllerMac.mm
    M Source/WebCore/platform/audio/MultiChannelResampler.cpp
    M Source/WebCore/platform/graphics/ComplexTextController.h
    M Source/WebCore/platform/graphics/cocoa/FontDatabase.cpp
    M Source/WebCore/platform/graphics/iso/ISOBox.cpp
    M Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm
    M Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm
    M Source/WebCore/platform/ios/WebCoreMotionManager.mm
    M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp
    M Source/WebCore/rendering/RenderThemeIOS.mm
    M Source/WebKit/Shared/WebEventConversion.cpp
    M Source/WebKit/Shared/glib/ArgumentCodersGLib.cpp
    M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
    M Source/WebKit/UIProcess/API/glib/WebKitContextMenuClient.cpp
    M Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.cpp
    M Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm
    M Source/WebKit/UIProcess/WebBackForwardList.cpp
    M Source/WebKit/UIProcess/gtk/ClipboardGtk4.cpp
    M Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp
    M Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp
    M Source/WebKit/WebProcess/glib/UserMediaCaptureManager.cpp

  Log Message:
  -----------
  Reduce use of Vector::uncheckedAppend() throughout the codebase
https://bugs.webkit.org/show_bug.cgi?id=263002

Reviewed by Brent Fulgham.

Reduce use of Vector::uncheckedAppend() throughout the codebase and replace
with more efficient idioms now that uncheckedAppend() has become an alias to
append().

* Source/WTF/wtf/JSONValues.h:
(WTF::containerSize):
* Source/WTF/wtf/URLParser.cpp:
(WTF::URLParser::syntaxViolation):
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp:
(WebCore::WebGPU::convertToBacking):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp:
(WebCore::GStreamerPeerConnectionBackend::dispatchPendingTrackEvents):
* Source/WebCore/contentextensions/ContentExtensionActions.cpp:
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::serialize const):
* Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:
(WebCore::ContentExtensions::ContentExtensionsBackend::actionsForResourceLoad const):
* Source/WebCore/contentextensions/DFABytecodeCompiler.cpp:
(WebCore::ContentExtensions::DFABytecodeCompiler::extractJumpTable):
* Source/WebCore/contentextensions/DFAMinimizer.cpp:
* Source/WebCore/contentextensions/MutableRangeList.h:
* Source/WebCore/css/typedom/ComputedStylePropertyMapReadOnly.cpp:
(WebCore::ComputedStylePropertyMapReadOnly::entries const):
* Source/WebCore/cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthLastChildOf):
* Source/WebCore/page/mac/ImageOverlayControllerMac.mm:
(WebCore::ImageOverlayController::updateDataDetectorHighlights):
* Source/WebCore/platform/audio/MultiChannelResampler.cpp:
(WebCore::MultiChannelResampler::MultiChannelResampler):
* Source/WebCore/platform/graphics/ComplexTextController.h:
* Source/WebCore/platform/graphics/cocoa/FontDatabase.cpp:
(WebCore::FontDatabase::collectionForFamily):
* Source/WebCore/platform/graphics/iso/ISOBox.cpp:
(WebCore::ISOBox::parse):
* Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
* Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm:
(WebCore::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
* Source/WebCore/platform/ios/WebCoreMotionManager.mm:
(-[WebCoreMotionManager sendAccelerometerData:]):
(-[WebCoreMotionManager sendMotionData:withHeading:]):
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
(WebCore::toRTCRtpCapabilities):
* Source/WebCore/rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::paintCheckboxDecorations):
(WebCore::RenderThemeIOS::adjustedPaintRect const): Deleted.
(WebCore::RenderThemeIOS::baselinePosition const): Deleted.
(WebCore::RenderThemeIOS::isControlStyled const): Deleted.
(WebCore::RenderThemeIOS::adjustMinimumIntrinsicSizeForAppearance const): Deleted.
(WebCore::RenderThemeIOS::adjustRadioStyle const): Deleted.
(WebCore::RenderThemeIOS::paintRadioDecorations): Deleted.
(WebCore::RenderThemeIOS::adjustTextFieldStyle const): Deleted.
(WebCore::RenderThemeIOS::paintTextFieldInnerShadow): Deleted.
(WebCore::RenderThemeIOS::paintTextFieldDecorations): Deleted.
(WebCore::RenderThemeIOS::adjustTextAreaStyle const): Deleted.
(WebCore::RenderThemeIOS::paintTextAreaDecorations): Deleted.
(WebCore::RenderThemeIOS::popupInternalPaddingBox const): Deleted.
(WebCore::canAdjustBorderRadiusForAppearance): Deleted.
(WebCore::RenderThemeIOS::adjustRoundBorderRadius): Deleted.
(WebCore::applyCommonButtonPaddingToStyle): Deleted.
(WebCore::adjustSelectListButtonStyle): Deleted.
(WebCore::RenderThemeMeasureTextClient::RenderThemeMeasureTextClient): Deleted.
(WebCore::adjustInputElementButtonStyle): Deleted.
(WebCore::RenderThemeIOS::adjustMenuListButtonStyle const): Deleted.
(WebCore::RenderThemeIOS::paintMenuListButtonDecorations): Deleted.
(WebCore::RenderThemeIOS::adjustSliderTrackStyle const): Deleted.
(WebCore::RenderThemeIOS::paintSliderTrack): Deleted.
(WebCore::RenderThemeIOS::adjustSliderThumbSize const): Deleted.
(WebCore::RenderThemeIOS::paintSliderThumbDecorations): Deleted.
(WebCore::RenderThemeIOS::paintProgressBar): Deleted.
(WebCore::RenderThemeIOS::sliderTickSize const): Deleted.
(WebCore::RenderThemeIOS::sliderTickOffsetFromTrackCenter const): Deleted.
(WebCore::RenderThemeIOS::adjustSearchFieldStyle const): Deleted.
(WebCore::RenderThemeIOS::paintSearchFieldDecorations): Deleted.
(WebCore::RenderThemeIOS::isSubmitStyleButton const): Deleted.
(WebCore::RenderThemeIOS::adjustButtonLikeControlStyle const): Deleted.
(WebCore::RenderThemeIOS::adjustButtonStyle const): Deleted.
(WebCore::RenderThemeIOS::paintButtonDecorations): Deleted.
(WebCore::shouldUseConvexGradient): Deleted.
(WebCore::RenderThemeIOS::paintPushButtonDecorations): Deleted.
(WebCore::RenderThemeIOS::platformActiveSelectionBackgroundColor const): Deleted.
(WebCore::RenderThemeIOS::platformInactiveSelectionBackgroundColor const): Deleted.
(WebCore::cachedFocusRingColor): Deleted.
(WebCore::cachedInsertionPointColor): Deleted.
(WebCore::RenderThemeIOS::systemFocusRingColor): Deleted.
(WebCore::RenderThemeIOS::platformFocusRingColor const): Deleted.
(WebCore::RenderThemeIOS::insertionPointColor): Deleted.
(WebCore::RenderThemeIOS::autocorrectionReplacementMarkerColor const): Deleted.
(WebCore::RenderThemeIOS::platformAnnotationHighlightColor const): Deleted.
(WebCore::RenderThemeIOS::shouldHaveSpinButton const): Deleted.
(WebCore::RenderThemeIOS::supportsFocusRing const): Deleted.
(WebCore::RenderThemeIOS::supportsBoxShadow const): Deleted.
(WebCore::cssValueSystemColorInformationList): Deleted.
(WebCore::systemColorFromCSSValueSystemColorInformation): Deleted.
(WebCore::systemColorFromCSSValueID): Deleted.
(WebCore::globalCSSValueToSystemColorMap): Deleted.
(WebCore::RenderThemeIOS::cssValueToSystemColorMap): Deleted.
(WebCore::RenderThemeIOS::setCSSValueToSystemColorMap): Deleted.
(WebCore::RenderThemeIOS::setFocusRingColor): Deleted.
(WebCore::RenderThemeIOS::setInsertionPointColor): Deleted.
(WebCore::RenderThemeIOS::systemColor const): Deleted.
(WebCore::RenderThemeIOS::pictureFrameColor): Deleted.
(WebCore::RenderThemeIOS::controlTintColor const): Deleted.
(WebCore::RenderThemeIOS::iconForAttachment): Deleted.
(WebCore::RenderThemeIOS::attachmentIntrinsicSize const): Deleted.
(WebCore::paintAttachmentIcon): Deleted.
(WebCore::paintAttachmentProgress): Deleted.
(WebCore::attachmentBorderPath): Deleted.
(WebCore::paintAttachmentBorder): Deleted.
(WebCore::RenderThemeIOS::paintAttachment): Deleted.
(WebCore::RenderThemeIOS::attachmentStyleSheet const): Deleted.
(WebCore::RenderThemeIOS::extraDefaultStyleSheet): Deleted.
(WebCore::RenderThemeIOS::paintSystemPreviewBadge): Deleted.
(WebCore::RenderThemeIOS::checkboxRadioBorderColor): Deleted.
(WebCore::RenderThemeIOS::checkboxRadioBackgroundColor): Deleted.
(WebCore::RenderThemeIOS::checkboxRadioBackgroundGradient): Deleted.
(WebCore::RenderThemeIOS::checkboxRadioIndicatorColor): Deleted.
(WebCore::RenderThemeIOS::paintCheckboxRadioInnerShadow): Deleted.
(WebCore::RenderThemeIOS::paintCheckbox): Deleted.
(WebCore::RenderThemeIOS::paintRadio): Deleted.
(WebCore::RenderThemeIOS::animationRepeatIntervalForProgressBar const): Deleted.
(WebCore::RenderThemeIOS::paintProgressBarWithFormControlRefresh): Deleted.
(WebCore::RenderThemeIOS::supportsMeter const): Deleted.
(WebCore::RenderThemeIOS::paintMeter): Deleted.
(WebCore::RenderThemeIOS::paintListButton): Deleted.
(WebCore::RenderThemeIOS::paintSliderTicks): Deleted.
(WebCore::RenderThemeIOS::paintSliderTrackWithFormControlRefresh): Deleted.
(WebCore::RenderThemeIOS::colorInputStyleSheet const): Deleted.
(WebCore::RenderThemeIOS::adjustColorWellStyle const): Deleted.
(WebCore::RenderThemeIOS::paintColorWell): Deleted.
(WebCore::RenderThemeIOS::paintColorWellDecorations): Deleted.
(WebCore::RenderThemeIOS::paintMenuListButtonDecorationsWithFormControlRefresh): Deleted.
(WebCore::RenderThemeIOS::adjustSearchFieldDecorationPartStyle const): Deleted.
(WebCore::RenderThemeIOS::paintSearchFieldDecorationPart): Deleted.
(WebCore::RenderThemeIOS::adjustSearchFieldResultsDecorationPartStyle const): Deleted.
(WebCore::RenderThemeIOS::paintSearchFieldResultsDecorationPart): Deleted.
(WebCore::RenderThemeIOS::adjustSearchFieldResultsButtonStyle const): Deleted.
(WebCore::RenderThemeIOS::paintSearchFieldResultsButton): Deleted.
* Source/WebKit/Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformTouchEvent::WebKit2PlatformTouchEvent):
* Source/WebKit/Shared/glib/ArgumentCodersGLib.cpp:
(IPC::ArgumentCoder<GRefPtr<GUnixFDList>>::encode):
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _fetchDataRecordsOfTypes:withOptions:completionHandler:]):
* Source/WebKit/UIProcess/API/glib/WebKitContextMenuClient.cpp:
* Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.cpp:
(WebKit::SimulatedInputKeyFrame::keyFrameFromStateOfInputSources):
(WebKit::SimulatedInputKeyFrame::keyFrameToResetInputSources):
* Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::evaluateJavaScriptFunction):
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticator::getAssertion):
* Source/WebKit/UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::backListAsAPIArrayWithLimit const):
(WebKit::WebBackForwardList::forwardListAsAPIArrayWithLimit const):
* Source/WebKit/UIProcess/gtk/ClipboardGtk4.cpp:
(WebKit::Clipboard::formats):
* Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::WebAutomationSessionProxy::setFilesForInputFileUpload):
* Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp:
(WebKit::IPCTestingAPI::JSIPC::serializedEnumInfo):
* Source/WebKit/WebProcess/glib/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::getMediaStreamDevices):

Canonical link: https://commits.webkit.org/269224@main

More information about the webkit-changes mailing list