[webkit-changes] [WebKit/WebKit] a6dd9b: Skip data URL when saving web page resources to disk

Sihui noreply at github.com
Wed Oct 11 11:17:06 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a6dd9b2c0fcb4eb48b2616f6d78960a0d9475d8c
      https://github.com/WebKit/WebKit/commit/a6dd9b2c0fcb4eb48b2616f6d78960a0d9475d8c
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2023-10-11 (Wed, 11 Oct 2023)

  Changed paths:
    M Source/WebCore/editing/MarkupAccumulator.cpp
    M Source/WebCore/editing/MarkupAccumulator.h
    M Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm

  Log Message:
  -----------
  Skip data URL when saving web page resources to disk
https://bugs.webkit.org/show_bug.cgi?id=262806
rdar://116593858

Reviewed by Ryosuke Niwa.

Data URL carries data in itself, so there is no need to create file for resource identified by data URL.

Test: WebArchive.SaveResourcesDataURL

* Source/WebCore/editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::resolveURLIfNeeded const):
(WebCore::MarkupAccumulator::frameForAttributeReplacement const):
(WebCore::MarkupAccumulator::frameForAttributeReplacement): Deleted.
* Source/WebCore/editing/MarkupAccumulator.h:
* Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm:

Canonical link: https://commits.webkit.org/269210@main




More information about the webkit-changes mailing list