[webkit-changes] [WebKit/WebKit] a2ddc4: Safari: audio elements with event listeners are no...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a2ddc404d28da5ea719bef25ead5d58e7a609ff0
      https://github.com/WebKit/WebKit/commit/a2ddc404d28da5ea719bef25ead5d58e7a609ff0
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2023-10-10 (Tue, 10 Oct 2023)

  Changed paths:
    A LayoutTests/media/media-garbage-collection-expected.txt
    A LayoutTests/media/media-garbage-collection.html
    M LayoutTests/media/video-test.js
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Source/WebCore/html/HTMLMediaElement.h
    M Source/WebCore/platform/audio/PlatformMediaSession.h

  Log Message:
  -----------
  Safari: audio elements with event listeners are not getting garbage collected
https://bugs.webkit.org/show_bug.cgi?id=262485
rdar://116347723

Reviewed by Youenn Fablet.

Clarify the implementation of HTMLMediaElement::virtualHasPendingActivity() to explicitly
handle the cases when an element may have eventListeners but will never fire an event
without its state being mutated through JavaScript.

* LayoutTests/media/media-garbage-collection-expected.txt: Added.
* LayoutTests/media/media-garbage-collection.html: Added.
* LayoutTests/media/video-test.js:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::virtualHasPendingActivity const):
(WebCore::HTMLMediaElement::hasLiveSource const): Deleted.
* Source/WebCore/html/HTMLMediaElement.h:

Canonical link: https://commits.webkit.org/269165@main