[webkit-changes] [WebKit/WebKit] 405e0b: Regression (268779 at main) A lot of Safari Reader te...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 405e0bba3951bc10d4b026ab04a4788c997f3c8c
      https://github.com/WebKit/WebKit/commit/405e0bba3951bc10d4b026ab04a4788c997f3c8c
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-10-10 (Tue, 10 Oct 2023)

  Changed paths:
    M Source/WebCore/loader/archive/ArchiveResource.cpp

  Log Message:
  -----------
  Regression (268779 at main) A lot of Safari Reader tests are failing
https://bugs.webkit.org/show_bug.cgi?id=262927
rdar://116606281

Reviewed by Alex Christensen.

In the Web archives used by Safari's reader tests, the resource response is
missing, causing ArchiveResource::create() to generate a synthetic response.
I am not sure why the response is missing from Safari's web archives, as it
seems to be present in web archives I generate locally (maybe an older
format?).

In any case, the synthetic response didn't have an HTTP status code set,
even when the URL is a HTTP/HTTPS one. This would trip the logic added in
268779 at main to validate the HTTP status code of CSS style sheets since the
status code is 0 instead of being in the 200-299 range.

To address the issue, I am updating ArchiveResource::create() to set a status
code of 200 on the synthetic network response if the URL is in the HTTP
family.

* Source/WebCore/loader/archive/ArchiveResource.cpp:
(WebCore::ArchiveResource::create):

Canonical link: https://commits.webkit.org/269140@main