[webkit-changes] [WebKit/WebKit] 486a57: 4x imported/mozilla/svg/text/* (layout-tests) are ...

Richard Robinson noreply at github.com
Tue Oct 10 06:49:22 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 486a57246e8e9c6ef4d2b7f3d10036d84d9060dc
      https://github.com/WebKit/WebKit/commit/486a57246e8e9c6ef4d2b7f3d10036d84d9060dc
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2023-10-10 (Tue, 10 Oct 2023)

  Changed paths:
    M Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm

  Log Message:
  -----------
  4x imported/mozilla/svg/text/* (layout-tests) are flaky image failures
https://bugs.webkit.org/show_bug.cgi?id=262916
rdar://114780887

Reviewed by Wenson Hsieh.

This is the effectively the same problem as https://bugs.webkit.org/show_bug.cgi?id=199196,
but this time in the `UI_TEXT_SELECTION_DISPLAY_INTERACTION` code path.

Fix by applying a similar workaround that fixed the aforementioned bug; this time, by temporarily
deactivating the text selection interaction which also hides all of its views, including the
highlight and handle views.

* Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:
(WTR::PlatformWebView::windowSnapshotImage):

Canonical link: https://commits.webkit.org/269138@main




More information about the webkit-changes mailing list