[webkit-changes] [WebKit/WebKit] f9a3a2: WebAssembly SIMD results in incorrect float values...

Justin Michaud noreply at github.com
Mon Oct 9 09:34:04 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f9a3a2147af0a89a67c74b9da7a291387c6cb39c
      https://github.com/WebKit/WebKit/commit/f9a3a2147af0a89a67c74b9da7a291387c6cb39c
  Author: Justin Michaud <justin_michaud at apple.com>
  Date:   2023-10-09 (Mon, 09 Oct 2023)

  Changed paths:
    A JSTests/wasm/stress/omg-simd-simple.js
    A JSTests/wasm/stress/omg-simd-stress.js
    A JSTests/wasm/stress/omg-simd-stress.wat
    M Source/JavaScriptCore/b3/air/AirLowerMacros.cpp

  Log Message:
  -----------
  WebAssembly SIMD results in incorrect float values and non working bitwise operations
https://bugs.webkit.org/show_bug.cgi?id=258302
rdar://111050621

Reviewed by Alexey Shvayka.

We accidentally clobber our input, causing some random SIMD bugs.

This was pretty difficult to isolate, even though the bug is so obvious.
The included (larger) test case actually serves as a pretty general way
to debug a differential jit-tier bug.

* JSTests/wasm/stress/omg-simd-simple.js: Added.
(from.string_appeared_here.import.as.assert.from.string_appeared_here.async test):
* JSTests/wasm/stress/omg-simd-stress.js: Added.
(from.string_appeared_here.import.as.assert.from.string_appeared_here.async test.):
(from.string_appeared_here.import.as.assert.from.string_appeared_here.async test):
* JSTests/wasm/stress/omg-simd-stress.wat: Added.
* Source/JavaScriptCore/b3/air/AirLowerMacros.cpp:
(JSC::B3::Air::lowerMacros):

Canonical link: https://commits.webkit.org/269080@main




More information about the webkit-changes mailing list