[webkit-changes] [WebKit/WebKit] db4f2b: AX: All methods in AXIsolatedObject should be fina...

Tyler Wilcock noreply at github.com
Sun Oct 8 16:38:03 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: db4f2bb7df509e9b2b4260e4cfb84dd9ee852f94
      https://github.com/WebKit/WebKit/commit/db4f2bb7df509e9b2b4260e4cfb84dd9ee852f94
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-10-08 (Sun, 08 Oct 2023)

  Changed paths:
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h

  Log Message:
  -----------
  AX: All methods in AXIsolatedObject should be final, not override
https://bugs.webkit.org/show_bug.cgi?id=262868
rdar://problem/116650535

Reviewed by Chris Fleizach.

This can help de-virtualize function calls:

https://github.com/llvm/llvm-project/blob/876334321f842edadcc0cd4241c76b59bb888b9e/clang/lib/AST/DeclCXX.cpp#L2260#L2261

AXIsolatedObject has no subclasses, so everything can be final.

* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:

Canonical link: https://commits.webkit.org/269059@main




More information about the webkit-changes mailing list