[webkit-changes] [WebKit/WebKit] cf6d4e: [IFC][Ruby] RubyFormattingContext::sizeAnnotationB...

Alan Baradlay noreply at github.com
Sun Oct 8 10:07:28 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cf6d4e0d9fc41d5bc300fe9c01f7c18d30030e3a
      https://github.com/WebKit/WebKit/commit/cf6d4e0d9fc41d5bc300fe9c01f7c18d30030e3a
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-10-08 (Sun, 08 Oct 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp

  Log Message:
  -----------
  [IFC][Ruby] RubyFormattingContext::sizeAnnotationBox should return visual size
https://bugs.webkit.org/show_bug.cgi?id=262845

Reviewed by Antti Koivisto.

We are at display content construction, all coords are supposed to be visual.

* LayoutTests/fast/ruby/overhang-vertical-no-overlap1.html:
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::appendInterlinearRubyAnnotationBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendIntercharacterRubyAnnotationBox):
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
(WebCore::Layout::RubyFormattingContext::sizeAnnotationBox):

Canonical link: https://commits.webkit.org/269057@main




More information about the webkit-changes mailing list