[webkit-changes] [WebKit/WebKit] c6e379: AX: accessibilityIsIgnored cache is not enabled at...

Joshua Hoffman noreply at github.com
Sat Oct 7 10:50:21 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c6e3790b95dce89d1332cdf978d12608ce5626dd
      https://github.com/WebKit/WebKit/commit/c6e3790b95dce89d1332cdf978d12608ce5626dd
  Author: Joshua Hoffman <jhoffman23 at apple.com>
  Date:   2023-10-07 (Sat, 07 Oct 2023)

  Changed paths:
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp

  Log Message:
  -----------
  AX: accessibilityIsIgnored cache is not enabled at updateChildrenForObjects level
https://bugs.webkit.org/show_bug.cgi?id=262800
rdar://problem/116589024

Reviewed by Tyler Wilcock.

We utilize the AXComputedObjectAttributeCache to cache the isIgnored value of objects
across certain scopes. Right now, it is enabled in the scope of
AXIsolatedTree::updateChildren.

This patch enables the cache in AXIsolatedTree::updateChildrenForObjects, allowing all
of the appends downstream to take advantage of the caching. In testing, this can save
up to 20% of samples of accessibilityIsIgnored.

* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateChildrenForObjects):

Canonical link: https://commits.webkit.org/269042@main




More information about the webkit-changes mailing list