[webkit-changes] [WebKit/WebKit] 75d236: Use a HashSet<CheckedRef<LocalFrame>> for Page::m_...

Chris Dumez noreply at github.com
Fri Oct 6 12:45:53 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 75d236ee7095eb07328cc0d02d8ccaecb3ddd8ee
      https://github.com/WebKit/WebKit/commit/75d236ee7095eb07328cc0d02d8ccaecb3ddd8ee
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-10-06 (Fri, 06 Oct 2023)

  Changed paths:
    M Source/WebCore/page/LocalFrame.cpp
    M Source/WebCore/page/LocalFrame.h
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/page/Page.h
    M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  -----------
  Use a HashSet<CheckedRef<LocalFrame>> for Page::m_rootFrames
https://bugs.webkit.org/show_bug.cgi?id=262721
rdar://116565539

Reviewed by Ryosuke Niwa.

Use a HashSet<CheckedRef<LocalFrame>> for Page::m_rootFrames instead of a WeakHashSet<LocalFrame>.
This set is used in a hot code path and using a WeakHashSet is unnecessarily inefficient.

* Source/WebCore/page/LocalFrame.cpp:
(WebCore::LocalFrame::LocalFrame):
(WebCore::LocalFrame::isRootFrame const):
* Source/WebCore/page/LocalFrame.h:
* Source/WebCore/page/Page.cpp:
(WebCore::Page::~Page):
(WebCore::Page::removeRootFrame):
* Source/WebCore/page/Page.h:
(WebCore::Page::rootFrames const):
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::updateRendering):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::hasRootFrames):

Canonical link: https://commits.webkit.org/269009@main




More information about the webkit-changes mailing list