[webkit-changes] [WebKit/WebKit] 6498f1: REGRESSION(268393 at main): [ macOS wk2 ] http/tests/...

Jean-Yves Avenard noreply at github.com
Fri Oct 6 04:11:11 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6498f1b92db2c0b460bb14ce529f8c71e081d1f9
      https://github.com/WebKit/WebKit/commit/6498f1b92db2c0b460bb14ce529f8c71e081d1f9
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2023-10-06 (Fri, 06 Oct 2023)

  Changed paths:
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h
    M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm

  Log Message:
  -----------
  REGRESSION(268393 at main): [ macOS wk2 ] http/tests/media/video-webm-stall.html is constantly timing out.
https://bugs.webkit.org/show_bug.cgi?id=262604
rdar://116443613

Reviewed by Youenn Fablet.

Once loading had started, the WebM player would continuously returned true
in didLoadingProgress(), by-passing the network stalling detection.
We needed the returned value to change back to false so that it only returns
true if we did do progress.

Covered by existing test being re-enabled.

* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h:
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm:
(WebCore::MediaPlayerPrivateWebM::didLoadingProgress const):

Canonical link: https://commits.webkit.org/268982@main




More information about the webkit-changes mailing list