[webkit-changes] [WebKit/WebKit] 8c8512: [GStreamer] VideoSink: handle spurious flush event...

[Alicia Boya García]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8c8512b76ac59ac53b371e7177f56e5c2ec89f9c
      https://github.com/WebKit/WebKit/commit/8c8512b76ac59ac53b371e7177f56e5c2ec89f9c
  Author: Alicia Boya Garcia <aboya at igalia.com>
  Date:   2023-10-06 (Fri, 06 Oct 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp

  Log Message:
  -----------
  [GStreamer] VideoSink: handle spurious flush events gracefully
https://bugs.webkit.org/show_bug.cgi?id=244776

Reviewed by Xabier Rodriguez-Calvar.

After discussing this issue with Edward from GStreamer during the last
hackfest, elements should, at least in principle, handle spurious
FLUSH_START and FLUSH_STOP events.

That's not to say that there may not be bugs when elements are hot
unlinked inside autoplugging elements, but according to this
understanding of the API a FLUSH_STOP without a FLUSH_START is not an
error condition and the WebKit video sink should handle it gracefully.

Still, this patch logs whether said spurious flushes occur, as that
information can be very valuable when debugging potential more complex
races involving autoplugging.

Closes https://bugs.webkit.org/show_bug.cgi?id=244776.

* Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp:
(WebKitVideoSinkProbe::WebKitVideoSinkProbe):
(WebKitVideoSinkProbe::deleteUserData):
(WebKitVideoSinkProbe::doProbe):
(webKitVideoSinkSetMediaPlayerPrivate):

Canonical link: https://commits.webkit.org/268980@main