[webkit-changes] [WebKit/WebKit] aff9d6: AX: AXIsolatedObject::objectAttributeValue should ...

Tyler Wilcock noreply at github.com
Thu Oct 5 10:02:08 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aff9d67b9c8fe4a6a0afe4b53207a9c5b46e7de0
      https://github.com/WebKit/WebKit/commit/aff9d67b9c8fe4a6a0afe4b53207a9c5b46e7de0
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h

  Log Message:
  -----------
  AX: AXIsolatedObject::objectAttributeValue should return an AXIsolatedObject
https://bugs.webkit.org/show_bug.cgi?id=262683
rdar://problem/116507428

Reviewed by Chris Fleizach.

This improves type safety, gives the optimizer more information to work with, and generally makes more
sense (an AXIsolatedObject should never be able to return the other AXCoreObject variant, AccessibilityObject).

* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::cellForColumnAndRow):
(WebCore::AXIsolatedObject::insertMathPairs):
(WebCore::AXIsolatedObject::focusedUIElement const):
(WebCore::AXIsolatedObject::scrollBar):
(WebCore::AXIsolatedObject::accessibilityHitTest const):
(WebCore::AXIsolatedObject::objectAttributeValue const):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:

Canonical link: https://commits.webkit.org/268922@main




More information about the webkit-changes mailing list