[webkit-changes] [WebKit/WebKit] 93421f: NativePromise can't take callbacks defined with `a...

Jean-Yves Avenard noreply at github.com
Thu Oct 5 07:22:59 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 93421fec4bd155e1115459f55e01423771bf2c85
      https://github.com/WebKit/WebKit/commit/93421fec4bd155e1115459f55e01423771bf2c85
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
    M Source/WTF/wtf/NativePromise.h
    M Tools/TestWebKitAPI/Tests/WTF/NativePromise.cpp

  Log Message:
  -----------
  NativePromise can't take callbacks defined with `auto`
https://bugs.webkit.org/show_bug.cgi?id=262678
rdar://116505009

Reviewed by Youenn Fablet.

Use more modern C++ (C++17) to compute the arguments and prototype of the
lambdas passed to whenSettle/then.
This allows to use the simpler `auto` declaration.

Thanks to Gerald Squelart for providing the technical solution.

Fly-by fixes: rename the remaining ResolveReject reference to Settled

Added API tests to check that compilation works as expected.

* Source/WTF/wtf/NativePromise.h:
* Tools/TestWebKitAPI/Tests/WTF/NativePromise.cpp:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/268913@main




More information about the webkit-changes mailing list