[webkit-changes] [WebKit/WebKit] e98470: Follow up fix for 'selenium' version bump.

dewei-zhu noreply at github.com
Thu Oct 5 00:26:00 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e984700817499a22aa028f1c0564b313481fad0e
      https://github.com/WebKit/WebKit/commit/e984700817499a22aa028f1c0564b313481fad0e
  Author: Dewei Zhu <dewei_zhu at apple.com>
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
    M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py
    M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py
    M Tools/Scripts/webkitpy/__init__.py

  Log Message:
  -----------
  Follow up fix for 'selenium' version bump.
https://bugs.webkit.org/show_bug.cgi?id=262669
rdar://116428857

Reviewed by Jonathan Bedard.

This change fixes two bugs in order to use 'selenium==4.12.0'.
First issue is that newer version of selenium need to be installed with 'wheel=True'.
Second issue is autoinstalled uses ZipFile module to extract zipfile which does not
preserve file 'x' permissions. Add code to preserve the file 'x' permission during
zip and tar file extractions.

* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py:
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(Package.Archive.unpack):
* Tools/Scripts/webkitpy/__init__.py:

Canonical link: https://commits.webkit.org/268900@main




More information about the webkit-changes mailing list