[webkit-changes] [WebKit/WebKit] d265fb: [WebGPU] built-in arrayLength is not supported

mwyrzykowski noreply at github.com
Wed Oct 4 17:47:53 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d265fb0d526aa8120a208bf62dc5a1e160400cc7
      https://github.com/WebKit/WebKit/commit/d265fb0d526aa8120a208bf62dc5a1e160400cc7
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-10-04 (Wed, 04 Oct 2023)

  Changed paths:
    M Source/WebGPU/WGSL/WGSL.h
    M Source/WebGPU/WebGPU/BindGroup.mm
    M Source/WebGPU/WebGPU/BindGroupLayout.h
    M Source/WebGPU/WebGPU/BindGroupLayout.mm
    M Source/WebGPU/WebGPU/ShaderModule.mm

  Log Message:
  -----------
  [WebGPU] built-in arrayLength is not supported
https://bugs.webkit.org/show_bug.cgi?id=262644
<radar://116482015>

Reviewed by Dan Glastonbury.

Add lengths to all buffers in a bind group so we can support
arrayLength() inside the shader.

* Source/WebGPU/WGSL/WGSL.h:
* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::Device::createBindGroup):
* Source/WebGPU/WebGPU/BindGroupLayout.h:
* Source/WebGPU/WebGPU/BindGroupLayout.mm:
(WebGPU::Device::createBindGroupLayout):
(WebGPU::BindGroupLayout::bufferSizeIndexForEntryIndex const):
* Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::ShaderModule::convertPipelineLayout):

Canonical link: https://commits.webkit.org/268884@main




More information about the webkit-changes mailing list