[webkit-changes] [WebKit/WebKit] 043b7c: Remove WebCore::StorageQuotaManager

Sihui noreply at github.com
Wed Oct 4 15:38:01 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 043b7ceee0be126ccc7bfd2659e8490959a8bf9a
      https://github.com/WebKit/WebKit/commit/043b7ceee0be126ccc7bfd2659e8490959a8bf9a
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2023-10-04 (Wed, 04 Oct 2023)

  Changed paths:
    M Source/WebCore/Headers.cmake
    M Source/WebCore/Modules/indexeddb/server/IDBServer.cpp
    M Source/WebCore/Modules/indexeddb/server/IDBServer.h
    M Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/storage/StorageQuotaManager.cpp
    M Source/WebCore/storage/StorageQuotaManager.h
    M Source/WebKit/NetworkProcess/NetworkProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkProcess.h
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in
    M Source/WebKitLegacy/Storage/InProcessIDBServer.cpp
    M Source/WebKitLegacy/Storage/InProcessIDBServer.h

  Log Message:
  -----------
  Remove WebCore::StorageQuotaManager
https://bugs.webkit.org/show_bug.cgi?id=262199
rdar://problem/116129143

Reviewed by Youenn Fablet.

WebCore::StorageQuotaManager was introduced to be used in both WebKitLegacy and WebKit code. However, WebKit now uses
WebKit::OriginQuotaManager, and WebKitLegacy does not actually have quota management for IndexedDB (any quota increase
will be approved, see InProcessIDBServer::quotaManager), so WebCore::StorageQuotaManager becomes unnecessary.

* Source/WebCore/Headers.cmake:
* Source/WebCore/Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::IDBServer):
* Source/WebCore/Modules/indexeddb/server/IDBServer.h:
* Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/storage/StorageQuotaManager.cpp:
(WebCore::StorageQuotaManager::create): Deleted.
(WebCore::StorageQuotaManager::StorageQuotaManager): Deleted.
(WebCore::StorageQuotaManager::requestSpaceOnMainThread): Deleted.
(WebCore::StorageQuotaManager::requestSpaceOnBackgroundThread): Deleted.
(WebCore::StorageQuotaManager::tryGrantRequest): Deleted.
(WebCore::StorageQuotaManager::updateQuotaBasedOnUsage): Deleted.
(WebCore::StorageQuotaManager::resetQuotaUpdatedBasedOnUsageForTesting): Deleted.
(WebCore::StorageQuotaManager::resetQuotaForTesting): Deleted.
* Source/WebCore/storage/StorageQuotaManager.h:
(): Deleted.
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::requestStorageSpace): Deleted.
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in:
* Source/WebKitLegacy/Storage/InProcessIDBServer.cpp:
(InProcessIDBServer::InProcessIDBServer):
(InProcessIDBServer::quotaManager): Deleted.
(storageQuotaManagerSpaceRequester): Deleted.
* Source/WebKitLegacy/Storage/InProcessIDBServer.h:

Canonical link: https://commits.webkit.org/268877@main




More information about the webkit-changes mailing list